-
Notifications
You must be signed in to change notification settings - Fork 273
Migrate Keyvault tool to recorded tests
#1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
scbedd
wants to merge
78
commits into
microsoft:main
Choose a base branch
from
scbedd:migrate-kv-to-recordings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+196
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getting closer to actually trying some of this on a per-test level
…the inheriting classes. maybe that's not a bad thing?
…e. we're going to make this happen!
…ctual integration testing
…. It actually stores a recording and properly locates the assets.json now! time to regenerate the client, ad the delegating handler, and get it ready for PR!
… now hitting random build failures because of nuget SOMEHOW
…grate without sanitizers etc.
…rely come from the testsettings file, then find a way to get that over to the testproxy fixture. the thought is to have two constructors for CommandTestsBase. One that accepts the fixture and one that doesn't.
…TestSettings fixture. Lazily start the proxy so that we only run it if in record or playback mode, we skip otherwise.
…izers for the check
…w all keyvault livetests except should_import_certificate are passing in playback. working on understanding which features are necessary to support that.
… the per-test matcher, but for some reason the attribute isn't being honored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR carries with it two globs of code:
keyvaultlivetests to recorded testsDay-to-day development is not yet affected. I need to add a couple more PRs to add stages that will run recorded tests in
CIbefore it will mean anything to devs.