Skip to content

Ignore MAP_SHARED #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CvvT wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ignore MAP_SHARED #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions litebox_shim_linux/src/syscalls/mm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ pub(crate) fn sys_mmap(
return Err(Errno::EINVAL);
}
if flags.intersects(
MapFlags::MAP_SHARED
| MapFlags::MAP_32BIT
MapFlags::MAP_32BIT
| MapFlags::MAP_GROWSDOWN
| MapFlags::MAP_LOCKED
| MapFlags::MAP_NONBLOCK
Expand All @@ -128,6 +127,15 @@ pub(crate) fn sys_mmap(
todo!("Unsupported flags {:?}", flags);
}

if flags.contains(MapFlags::MAP_SHARED) {
#[cfg(debug_assertions)]
litebox::log_println!(
litebox_platform_multiplex::platform(),
"Warning: MAP_SHARED is not fully supported yet, changes are not reflected to the underlying file.",
);
}
let flags = flags - MapFlags::MAP_SHARED;

let aligned_len = align_up(len, PAGE_SIZE);
if aligned_len == 0 {
return Err(Errno::ENOMEM);
Expand Down
Loading