Skip to content

Allow ints to be written as floats in json_serializer #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 4 commits into from
Sep 9, 2025
Merged

Allow ints to be written as floats in json_serializer #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44fa5b9
Allow ints to be written as floats in json_serializer
Sep 1, 2025
45e6b7d
Added tests for json serialization writer
Sep 9, 2025
acff950
Merge branch 'main' into 495-improve-int-float-serialization
pangeorg Sep 9, 2025
880bf08
Remove added formatting
Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serialization/json/kiota_serialization_json/json_serialization_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ def write_float_value(self, key: Optional[str], value: Optional[float]) -> None:
key (Optional[str]): The key to be used for the written value. May be null.
value (Optional[float]): The float value to be written.
"""
if isinstance(value, float):
if isinstance(value, (float, int)):
if key:
self.writer[key] = value
self.writer[key] = float(value)
else:
self.value = value
self.value = float(value)

def write_uuid_value(self, key: Optional[str], value: Optional[UUID]) -> None:
"""Writes the specified uuid value to the stream with an optional given key.
Expand Down
8 changes: 8 additions & 0 deletions packages/serialization/json/tests/unit/test_json_serialization_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ def test_write_float_value():
assert content_string == '{"gpa": 3.2}'


def test_write_float_value_with_int():
json_serialization_writer = JsonSerializationWriter()
json_serialization_writer.write_float_value("float", 3)
content = json_serialization_writer.get_serialized_content()
content_string = content.decode("utf-8")
assert content_string == '{"float": 3.0}'


def test_write_uuid_value():
json_serialization_writer = JsonSerializationWriter()
json_serialization_writer.write_uuid_value("id", UUID("8f841f30-e6e3-439a-a812-ebd369559c36"))
Expand Down