Handle VM disconnection gracefully and reorder termination logic#626
Merged
wenytang-ms merged 2 commits intomicrosoft:mainfrom Apr 30, 2026
Merged
Handle VM disconnection gracefully and reorder termination logic#626wenytang-ms merged 2 commits intomicrosoft:mainfrom
wenytang-ms merged 2 commits intomicrosoft:mainfrom
Conversation
Wrap vm.dispose() in a try/catch to ignore VMDisconnectedException when the VM has already disconnected (e.g. process terminated) to avoid spurious errors during detach. Reorder calls in DisconnectRequestHandler to invoke terminate() before detach() when terminateDebuggee is true and the session is not attached, ensuring the debuggee is terminated prior to detaching.
zepedrocosta
requested review from
chagong,
jdneo,
testforstephen and
wenytang-ms
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
wenytang-ms
reviewed
Apr 29, 2026
Wrap debugSession.terminate() in a try/finally so debugSession.detach() is always invoked when terminateDebuggee is true and the session is not attached. This ensures the session is detached even if terminate() throws, avoiding potential dangling sessions. Other detach logic is unchanged.
wenytang-ms
approved these changes
Apr 30, 2026
Contributor
|
@zepedrocosta thank you for your contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes in #620 the stop button wasn't working properly. The action wasn't executed and the process just kept running.
The
terminate()now is called beforedetach()when terminating the debuggee, ensuring proper shutdown sequence.