Repository navigation
fix(react-headless-components-preview): dismiss Popover on focus exit by default #36929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paul Mardling (PaulGMardling)
wants to merge
13
commits into
microsoft:master
Choose a base branch
from
PaulGMardling:paulgmardling-39630-headless-focus-dismissal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c483fa4
feat(react-headless-components-preview): add opt-in Popover focus-exi…
PaulGMardling 4edd875
fix(react-headless-components-preview): dismiss on focus exit by default
PaulGMardling fe52506
fix(react-headless-components-preview): harden focus-boundary observa…
PaulGMardling 6cc19f9
fix(react-headless-components-preview): reconcile settled focus owner…
PaulGMardling 9c5cd59
fix(react-headless-components-preview): retain complete owned shadow …
PaulGMardling ce116ba
fix(react-headless-components-preview): harden Popover document lifec…
PaulGMardling 706bfbd
Merge master into Popover focus-dismissal branch
PaulGMardling 92e88b4
fix(react-headless-components-preview): address Popover CI failures
PaulGMardling e9260d0
fix(react-headless-components-preview): preserve hover and ancestor-f…
PaulGMardling 57963a1
fix(react-headless-components-preview): retain logical Portal boundaries
PaulGMardling 303cd00
test: consolidate headless Popover focus regressions
PaulGMardling 2522d10
test: consolidate Popover regression suites
PaulGMardling 9cde443
fix: make Popover Portal stories SSR and React 17 compatible
PaulGMardling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-headless-components-preview-a73dd995-4801-4e2d-a38e-22b587c50e43.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "fix: dismiss non-modal Popover on focus exit across same-origin frames, preserving logical Portal hover, initial trigger Portal focus, and destination focus", | ||
| "packageName": "@fluentui/react-headless-components-preview", | ||
| "email": "paulmardling@microsoft.com" | ||
| } | ||
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-portal-a79d9baf-03ac-4063-8281-fd57a169d3ca.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "fix: establish portal virtual ownership during layout for focus observers", | ||
| "packageName": "@fluentui/react-portal", | ||
| "email": "paulmardling@microsoft.com" | ||
| } |
56 changes: 36 additions & 20 deletions
56
...react-components/react-headless-components-preview/library/docs/popover-spec.md
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.