fix(web-components): defer fallback custom-state attributes - #36722
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 1 commit into
Open
Conversation
Sylvester Kaczmarek (sylvesterkaczmarek)
requested a review
from a team
as a code owner
September 10, 2026 13:23
|
Very well. Thanks! |
|
Just a remark: isn't textarea affected by the same problem too? |
Author
|
Yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The attribute fallback for CSS custom states mutates the host during construction. With
:state()unsupported,document.createElement('fluent-tablist')fails because the constructor addsstate--horizontalbefore returning.New Behavior
Queue fallback attribute changes through FAST's DOM update queue. This keeps construction attribute-free and preserves toggle/swap ordering, including state changes before connection. The native
ElementInternals.statespath is unchanged.Adds three browser regressions and a patch change file. This fixes the shared web-components implementation; Blazor will need the resulting package release.
Validation
Tests used the repository's FAST browser harness through focused Nx targets, Playwright 1.56.1 and cached Chromium build 1208. Firefox, WebKit, and the full monorepo suite were not run.
Related Issue
Addresses microsoft/fluentui-blazor#5262.
The consumer issue was closed during implementation because older Chrome versions are outside Blazor's support policy. The maintainer nevertheless explicitly welcomed a contribution fixing the fallback: microsoft/fluentui-blazor#5262 (comment).