fix(charts): improve legends accessibility and update snapshots#36426
Open
v-baambati wants to merge 5 commits into
Open
fix(charts): improve legends accessibility and update snapshots#36426v-baambati wants to merge 5 commits into
v-baambati wants to merge 5 commits into
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 3 | Changed |
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 4 | Changed |
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1203 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 478 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png | 480 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1098 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 526 | Changed |
vr-tests-react-components/Charts-Legend 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-Legend.Overflow.expanded.chromium.png | 4956 | Changed |
| vr-tests-react-components/Charts-Legend.Overflow - Dark Mode.expanded.chromium.png | 4253 | Changed |
| vr-tests-react-components/Charts-Legend.Overflow - RTL.expanded.chromium.png | 4996 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 18 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 512 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 72 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 78 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle - Dark Mode.default.chromium.png | 6 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1319 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
krkshitij
reviewed
Jul 24, 2026
| return ( | ||
| <Menu> | ||
| <MenuTrigger disableButtonEnhancement> | ||
| <MenuButton ref={ref}>{displayLabel}</MenuButton> |
Contributor
There was a problem hiding this comment.
Why are all these changes necessary? Did you try assigning the option role to the MenuButton instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LegendsandOverflowMenuimplementation details for accessibility fixesChanges
packages/charts/react-charts/library/src/components/Legends/Legends.tsxpackages/charts/react-charts/library/src/components/Legends/OverflowMenu.tsxpackages/charts/react-charts/library/src/components/**/__snapshots__/Notes
upstream/masterand contains 3 commits on top, including the legends fix and snapshot refresh.