fix: tree selection default behavior + warning, and updating other examples with incorrect a11y info#36408
Open
smhigley wants to merge 4 commits into
Open
fix: tree selection default behavior + warning, and updating other examples with incorrect a11y info#36408smhigley wants to merge 4 commits into
smhigley wants to merge 4 commits into
Conversation
…amples with incorrect a11y info
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bsunderhus
reviewed
Jul 20, 2026
Comment on lines
+123
to
+130
| if (typeof onClick === 'function') { | ||
| onClick(event); | ||
| } | ||
| // if onClick is not defined and this is not an expand/collapse node and the treeitem is selectable, | ||
| // then we should toggle the selection state on click | ||
| else if (selectionMode !== 'none' && itemType === 'leaf') { | ||
| selectionRef.current?.click(); | ||
| } |
Contributor
There was a problem hiding this comment.
@smhigley can you add a e2e test for this use case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with Tree that stem from having multiple actions on the same leaf node:
onClickhandler. This allows selection to work with voice control, mobile screen readers, and macOS VoiceOver (or at least as long as the external team doesn't explicitly make it inaccessible).Fixes ADO issue