docs: minor story-only accessibility fixes in v9 stories#36406
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
|
a follow up issue has been created |
PaulGMardling
left a comment
There was a problem hiding this comment.
Approving because these changes address the accessibility issues reported in the linked ADOs for the affected Storybook examples.
This resolves the audited scenarios by ensuring that focusable PopoverSurface elements have accessible names.
However, it does not change the underlying PopoverSurface behavior: non-modal surfaces still receive role="group" by default, regardless of whether their content represents a logical group of UI objects.
|
hm, sort of. The changes in that PR are not ones I'd recommend -- if a Popover isn't named, that doesn't make it a dialog, and group is still a more appropriate role. The dialog role has an impact on screen reader virtual cursor interactions and voice control overlays as well, and we wouldn't want that for popovers by default. (The impact I'm talking about is solely from the role, not from other methods of making the background inert or unfocusable). Additionally, the dialog role also wouldn't fix the root issue in all screen readers. The problem is for a popover (or dialog) with no focusable content to reliably read its content when opened for screen reader users, it needs to both set focus to the PopoverSurface and have an accessible name defined. It's hard for us to handle that out of the box though, since we'd need to do something iffy like try to query for focusable descendants and also guess at what the accName should be. There are multiple accName approaches that are either bad or good depending on the length and type of popover content, so really a case-by-case authoring concern 😬 |
This fixes three issues:
Fixes ADO issues: