feat(react-headless-components-preview): switch to subpaths exports#36036
Open
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Open
feat(react-headless-components-preview): switch to subpaths exports#36036dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Hotell
reviewed
Apr 23, 2026
Contributor
Hotell
left a comment
Hotell
left a comment
There was a problem hiding this comment.
left some comments / questions. otherwise looks good ty
| "node": "./lib-commonjs/index.js", | ||
| "import": "./lib/index.js", | ||
| "require": "./lib-commonjs/index.js" | ||
| "./*": { |
Contributor
There was a problem hiding this comment.
this is what I was pointing out with the suggestion to have src/public/*, if anyone adds something by "mistake" to src/* it's gonna be exposed as public api + accessible within monorepo for usage.
also it probably doesn't make sense to expose the index.ts for public as it doesn't exposes anything
Contributor
Author
There was a problem hiding this comment.
that's a valid point, but honestly, src/public/* isn't any better, it has the same problem. Lets go with explicit exports map defined in package.json, as it will allow us to keep the package structure as it is now, wdyt?
I've already updated the PR 😄
dmytrokirpa
force-pushed
the
feat/headless-subpath-imports
branch
4 times, most recently
from
fe2d854 to
4460694
Compare
dmytrokirpa
changed the title
dmytrokirpa
force-pushed
the
feat/headless-subpath-imports
branch
4 times, most recently
from
8c093ba to
5b472a7
Compare
dmytrokirpa
changed the title
dmytrokirpa
force-pushed
the
feat/headless-subpath-imports
branch
from
5b472a7 to
06b9431
Compare
dmytrokirpa
commented
Apr 24, 2026
| const config = { | ||
| react: { | ||
| 17: { | ||
| runConfig: { 'type-check': { configPath: 'tsconfig.lib.json' } }, |
Contributor
Author
There was a problem hiding this comment.
needed for passing the "moduleResolution" : "bundler"
dmytrokirpa
force-pushed
the
feat/headless-subpath-imports
branch
from
06b9431 to
1923afa
Compare
dmytrokirpa
force-pushed
the
feat/headless-subpath-imports
branch
from
1923afa to
a3396e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"./*"entry with an explicit export map — every subpath is individually enumerated inpackage.jsonto prevent accidental exposure of internal modules"./radio-group","./message-bar","./tab-list") following the same convention used across the rest of the Fluent UI v9 package namespace"."barrel export — consumers must import from the specific component subpathexportsmap, catching gaps at CI time@fluentui/react-headless-components-preview/radio-group, etc.)Why explicit over wildcard
A wildcard
"./*"passes through any path under the package root — including build artifacts, internal utilities, and anything else that happens to exist inlib/. Explicit entries make the public surface intentional and auditable.Why kebab-case subpath keys
Kebab-case is consistent with how the rest of the Fluent UI v9 ecosystem names things in package paths and aligns with common Node.js ecosystem conventions for subpath exports . Removing the barrel export encourages consumers to import only what they need, enabling better tree-shaking.
Export map