fix: ToggleButton provides an opt-in isAccessible variant for accessible checked colors#35837
Open
smhigley wants to merge 3 commits intomicrosoft:masterfrom
Open
fix: ToggleButton provides an opt-in isAccessible variant for accessible checked colors#35837smhigley wants to merge 3 commits intomicrosoft:masterfrom
smhigley wants to merge 3 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 198 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 966 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
If the author doesn't have an icon in their ToggleButton, or doesn't change the icon between visually distinct variants for checked vs. unchecked, the ToggleButton doesn't meet a11y requirements for color contrast / not color alone for checked vs. unchecked in any appearance variant:
unchecked:
checked:
Note: the outline variant does increase the border thickness, but since the border itself has less than 3:1 contrast, it doesn't help. In our story we do have an icon change so these specific buttons would be OK, but would fail without the icon.
New Behavior
An opt-in variant to each appearance that has actual contrasting color changes (or a stroke) to indicate the checked state. This was done w/ the design team, and checked w/ partners. In the future/v10, we should make the opt-in behavior the default, but for now it's opt-in.
unchecked:
checked:
I also added a story for the variant, and a11y docs for ToggleButton that explain when & why to use it.
Related Issue(s)