fix(react-motion): cleanup animation handle on unmounted component #35617
+99
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Previous Behavior
Components that are created via
createPresenceComponent()and usingunmountOnExitwill be retained till a host component will be unmounted.2026-01-05.11.32.19.mp4
Typical scenario
DialogDialogAnimationHandlebeing retained even when an element is removed from DOMNew Behavior
If an element is removed from DOM, it's safe to cleanup references. The problem is that
AnimationHandleis created by aReact.useCallbackinuseAnimateAtomsInSupportedEnvironment()that referenceselement, it's an actual retainer:I moved creation of objects to
createHandle(), so closures don't have a reference to an element anymore and only keep references toanimations.dispose()method introduces to clear references to animations..dispose()is called inReact.useEffect()once a DOM element is gone, this fixes the issue:P.S. Unit test is not added as it required hijacking internals deeply.
Related Issue(s)
Fixes #35534