Refresh FinOps hub upgrade procedure for multi-version FOCUS adoption#2123
Refresh FinOps hub upgrade procedure for multi-version FOCUS adoption#2123flanakin wants to merge 5 commits into
Conversation
…#2121) Update the canonical "add a new FOCUS version" procedure to reflect the six additional steps surfaced during FOCUS 1.4 scoping (Cost Management dependency check, open-data metadata, conformance regen, plugin updates, changelog) and add guidance for handling two FOCUS versions in one cycle (GA + preview). Clarify the hub-schema-to-FOCUS-version relationship and preview convention in data-model.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Refreshes the FinOps hubs documentation playbook for adding new FOCUS versions, with explicit guidance for preview vs GA handling and a clearer explanation of how hub schema versions relate to FOCUS spec versions.
Changes:
- Expanded the “add a new FOCUS version” procedure with dependency checks, open-data metadata, conformance regeneration, plugin reference updates, and changelog guidance.
- Added guidance for handling two FOCUS versions in a single release cycle (GA + preview) and keeping unversioned functions pinned to latest GA.
- Clarified in user docs that hub schema versions mirror the FOCUS version they natively ingest, and documented the preview convention.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/templates/finops-hub/docs/README.md | Updates the canonical upgrade procedure and adds multi-version (GA + preview) guidance. |
| docs-mslearn/toolkit/hubs/data-model.md | Clarifies schema-version-to-FOCUS coupling and documents preview behavior for hub schemas. |
Conformance reports are generated only against official Microsoft Cost Management FOCUS releases, not as part of adding a new FOCUS version to FinOps hubs. Removing the step keeps the procedure scoped to the hub-specific workstream. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🤖 [AI][Claude Code] Additional change beyond Copilot review While addressing the grammar fix on Updated both
Phase 4 ( |
- Reword data-model.md:66 grammar (per Copilot). - Decouple hub preview status from Cost Management export availability. Preview now means the FOCUS spec is still working draft. Cost Management lag is a separate operational concern that does not gate hub GA. - Update README step 0 to match. Co-Authored-By: copilot-pull-request-reviewer <copilot-pull-request-reviewer@users.noreply.github.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🤖 [AI][Claude Code] PR Update Summary Addressed: 1 review thread + scope expansion
|
RolandKrummenacher
left a comment
There was a problem hiding this comment.
Review — Phase 0 docs refresh
Docs-only change; verified all relative links resolve from src/templates/finops-hub/docs/ (schemas folder, open-data/dataset-metadata/, the 5 agent-skill/plugin paths, and the changelog), the open-data naming convention matches existing files, and the new up-conversion explanation is consistent with the existing "Versioning strategy" section. Nice cleanup of the playbook. A few things before merge:
1. Typo (should fix) — README step 0.1: "to prevent customer churn sinc FOCUS working drafts may change" → since.
2. PR description is out of sync with the diff — The summary says step 0 should "ship hub support as preview" and that data-model.md documents a "preview convention / unversioned aliases stay pinned to the latest GA schema." The actual diff says the opposite: README step 0.2 reads "the hub schema can still ship as GA," and data-model.md has no preview-convention text (only "export availability … is separate from FinOps hub support"). The body also lists "steps 5-8" but only 5–7 landed. Please reconcile the body with what shipped so intent is clear.
3. Forward-dated content in a published Learn doc (confirm intent) — data-model.md now publishes a 15+ → v1_4 → 1.4 table row plus v1_4/Costs_v1_4 examples. Since this is Phase 0 and 1.4 support hasn't shipped, this MS Learn page would publicly state 1.4 is supported ahead of release. If docs-mslearn publishes on merge rather than gated to the 1.4 release, consider holding the v1_4 row/examples for a later phase.
Nits (optional)
- README 5.1 / 5.2: "Create a
FocusCost_<version>.jsonfile into [folder]" → "in". - data-model.md: "pull from all tables and transform it" → "them" (refers to tables).
Low-risk overall — no correctness, performance, or security concerns. Recommend fixing the typo and reconciling the GA-vs-preview discrepancy; resolve #3 based on the docs publishing cadence.
Summary
Phase 0 of FOCUS 1.4 work (parent: #2120). Refreshes the canonical "add a new FOCUS version" procedure before any 1.3/1.4 schema work begins, so subsequent phases follow a consistent, version-agnostic playbook.
Changes
src/templates/finops-hub/docs/README.mdBuild-FocusConformance.ps1, plugin skill file updates (5 listed paths), changelog entry.docs-mslearn/toolkit/hubs/data-model.mdNo FOCUS 1.3/1.4-specific content lands here — that's tracked in later phases.
Closes #2121
Test plan