fix: create singleton decorator #100
Open
+52
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle_fab_config_mode
…de' of https://github.com/microsoft/fabric-cli into dev/aviatcohen/avoidReLoginWhenSwitchingToInteractiveMode
ayeshurun
reviewed
Dec 24, 2025
| instances[class_] = class_(*args, **kwargs) | ||
| return instances[class_] | ||
|
|
||
| # Add a reset method to the decorator function for testing purposes |
Collaborator
There was a problem hiding this comment.
if looks like we don't use reset_instance in code, only in tests. if so, let's remove it :) if necessary we will add in the future
Collaborator
Author
There was a problem hiding this comment.
we use it in the tests: test_config and test_fab_interactiveCLI
Collaborator
Author
There was a problem hiding this comment.
This was only used in tests, so I removed it. I don’t think the code should contain test‑specific logic.
ayeshurun
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
✨ Description of new changes
To enable reuse, refactor the singleton logic currently in fab_context into a decorator and apply that decorator within fab_interactive.