Repository navigation
Fix compilation with stable Rust - #1002
Conversation
| } | ||
| // | ||
| // TODO: Due to borrowing issues in stable Rust 1.99 (and possibly subsequent versions), | ||
| // we cannot use any methods on double_cache (e.g. iterators or indexing helpers). |
There was a problem hiding this comment.
Leonard Hecker (@lhecker) the comment seems inaccurate. It isn't a bug, regression nor "issue" on stable, stable is working exactly as intended. It's a difference in how the new borrow checker on nightly works vs. Rust stable.
See running RUSTFLAGS="-Zpolonius=off" cargo +nightly build --release before this commit, produces same error as building with stable did.
There was a problem hiding this comment.
Something can work as intended and still be an issue for me. They are not mutually exclusive.
There was a problem hiding this comment.
True, but still misleading comment if read without said internal knowledge of author's thoughts.
There was a problem hiding this comment.
Well, arguably, it's an issue if disabling the new borrow checker--which changes this behavior--resolves it. Somewhat of an existence proof of there being a problem, yeah?
Behavior X is present in stable.
Behavior X is not present in nightly, unless you toggle the "go back to the thing that had behavior X" switch.
Put another way: if it wasn't an issue, why would it appear to be fixed by the new (better, less buggy, better-researched, etc. etc. etc.) borrow checker?
There was a problem hiding this comment.
While I'm not a native English speaker, I consider this sentence reasonable and will keep it as-is. It's unclear at this point who of us is in the wrong, so I'll wait for a tie breaker.
That said, this is just a comment. It does not bear a significant meaning in the first place.
There was a problem hiding this comment.
Yeah, it's largely besides the point. It's a code comment after all. Do with it what you want, or not.
I don't think any of us are necessarily "in the wrong" as a blanket statement, as our views aren't necessarily contradictory of each other, it's just that none of us are understanding each other.
Maybe I'll just say sorry, I retract my point. Do with it what you will, it's your TODO comment after all, if it's useful to you, who am I to contest it.
Closes #1000