Remove quarantined es5-ext dependency#632
Open
jiridanek wants to merge 1 commit into
Open
Conversation
es5-ext (0.10.64) is quarantined by Nexus Firewall (sonatype-2022-2248) due to undisclosed postinstall code execution. Remove the direct es5-ext dependency from connections package.json, as it is an ES5 polyfill unnecessary for modern Node.js targets. Add npm override to handle the remaining transitive es5-ext from the websocket package. Ref: microsoft#420 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@jiridanek please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree company="Red Hat" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
es5-ext@0.10.64dependency fromts/src/connections/package.json— it is an ES5 polyfill unnecessary for modern Node.js targets (connor4312 noted this in TS SDK depends on a vulnerable version of es5-ext #420).es5-ext(fromwebsocket@^1.0.28) to@unes/es5-ext@0.10.64-1, a community fork without the postinstall script.es5-extis quarantined by Nexus Firewall (sonatype-2022-2248) due to undisclosed postinstall code execution, blocking hardened supply chain builds.Ref: #420
References
websocketpackage dropping es5-extMade with Cursor