Reduce the content exported by Namespace.0.h#1595
Open
YexuanXiao wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the code generation for Namespace.0.h to reduce what gets exported from the winrt::impl namespace (primarily relevant for C++20 module builds where WINRT_EXPORT expands to export extern "C++").
Changes:
- Added a
wrap_impl_namespace_without_exporthelper to emitnamespace winrt::impl { ... }withoutWINRT_EXPORT. - Updated
write_namespace_0_hgeneration to use the non-exportingwinrt::implwrapper for categories/names/guids and most ABI-related output. - Split struct ABI generation into two passes (
write_struct_abi_typeandwrite_struct_abi_specialization) so only the struct ABI type emission remains under the exporting wrapper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cppwinrt/file_writers.h | Updates Namespace.0.h emission to selectively avoid WINRT_EXPORT and splits struct ABI output into separate wrapped blocks. |
| cppwinrt/code_writers.h | Adds wrap_impl_namespace_without_export and splits struct ABI writer into type vs abi<> specialization emitters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.