Allow embedded builds to compile out internal logging - #1533
Open
bmehta001 wants to merge 3 commits into
Open
Conversation
Expose MATSDK_DISABLE_LOGGING so consumers can remove diagnostic logging without patching 1DS or disabling telemetry upload. Files changed: - CMake option and internal target configuration - default logging feature selection and PAL warning fixes - embedding documentation and CI coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 49c171ca-76ba-4688-afaf-df59129cda4f
Honor MATSDK_DISABLE_LOGGING in the Android PAL path so embedded builds do not retain internal Logcat output or its header dependency. Files changed: - lib/pal/PAL.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Honor MATSDK_DISABLE_LOGGING across the JNI wrapper and remove the unused liblog dependency so Android embedding builds retain no internal Logcat path. Files changed: - lib/CMakeLists.txt - lib/android_build/maesdk/build.gradle - lib/jni/LogManager_jni.cpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0ab71a08-8e5c-4fdd-ae7e-466debb4860f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MATSDK_DISABLE_LOGGINGCMake optionliblogdependency when internal logging is disabledThis lets embedded consumers remove internal SDK diagnostics without patching 1DS and without disabling telemetry collection or upload.
Validation
__android_log*references orliblogdependencygit diff --check