Use the canonical SQLite CMake target - #1532
Open
bmehta001 wants to merge 2 commits into
Open
Conversation
Avoid CMake 4.3+ developer warnings for static consumers while preserving compatibility with older FindSQLite3 modules and preloaded legacy targets. Files changed: - CMake dependency resolution and installed package helpers - SDK, Android, and test target links - in-repo vcpkg overlay port Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the CMake target migration focused by dropping the legacy target adapter and updating the embedding fixture to provide SQLite3::SQLite3 directly. Files changed: - cmake/MSTelemetryConfig.cmake.in - cmake/MatsdkDependencyTargets.cmake - tests/embedding/CMakeLists.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 037b338a-b5c0-4989-b9d3-36681fb822f5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite3::SQLite3, the canonical target in CMake 4.3+SQLite::SQLite3target for CMake 3.15-4.2 and embedding consumersBUILD_IOSoption from the in-repo vcpkg overlayValidation
-Werror=author-Werror=dev-Werror=dev