Skip to content

fix: Deployment Failure and pipeline failure for CPAsh#628

Merged
Roopan-Microsoft merged 6 commits into
devfrom
Ash17-Bicep17-Changes17
Jun 17, 2026
Merged

fix: Deployment Failure and pipeline failure for CPAsh#628
Roopan-Microsoft merged 6 commits into
devfrom
Ash17-Bicep17-Changes17

Conversation

@Ashwal-Microsoft

@Ashwal-Microsoft Ashwal-Microsoft commented Jun 16, 2026

Copy link
Copy Markdown

This pull request enhances Azure region quota checking and deployment workflows to improve reliability, user feedback, and support for additional regions. The main changes include a major rewrite of the checkquota.sh script for better region selection and error handling, updates to Bicep files for new region support, and improved CI/CD integration.

Quota Checking Improvements:

  • infra/scripts/checkquota.sh: Completely rewritten to prioritize user-specified regions, automatically fall back to allowed regions, and provide clear feedback on quota status. The script now exports the selected region and failure flags for CI/CD, and gives actionable guidance when quota is insufficient. [1] [2]
  • infra/scripts/quota_check_params.sh: Updates output messaging for clarity, aligns region lists with deployment parameters, and ensures CI/CD environment variables are set appropriately on failure or success. [1] [2] [3]

Region Support and Deployment Logic:

  • infra/main.bicep, infra/main_custom.bicep: Adds swedencentral to allowed regions and replica region pairs, expanding deployment options. [1] [2] [3] [4]
  • infra/main.bicep, infra/main_custom.bicep: Updates module dependencies to ensure correct deployment order when private networking is enabled. [1] [2]

CI/CD Workflow Adjustments:

  • .github/workflows/deploy.yml, .github/workflows/job-deploy.yml: Simplifies quota failure detection and ensures the correct environment flags are set for downstream steps. [1] [2]

These changes collectively make quota checks more robust, improve deployment flexibility, and enhance the developer/operator experience during deployment.## Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves deployment reliability by tightening Azure OpenAI quota prechecks, expanding supported deployment regions, and simplifying CI/CD handling around quota outcomes.

Changes:

  • Rewrites infra/scripts/checkquota.sh to select a deployable region (with fallback) and export results for workflows.
  • Updates quota-check defaults/messaging in infra/scripts/quota_check_params.sh to align with the Bicep-allowed region set.
  • Extends Bicep region support (adds swedencentral) and adjusts private-endpoint module dependencies; simplifies workflow quota-failure detection.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
infra/scripts/quota_check_params.sh Updates default region list and enhances user-facing quota failure/success messaging + CI env exports.
infra/scripts/checkquota.sh Replaces the quota-check logic with a region-selection flow and CI-friendly outputs.
infra/main.bicep Adds swedencentral to allowed locations/replica pairs; adds explicit dependencies for AI Services private endpoint module.
infra/main_custom.bicep Mirrors main.bicep changes for custom deployments (region + dependency updates).
.github/workflows/job-deploy.yml Simplifies quota failure detection logic in the deployment job workflow.
.github/workflows/deploy.yml Simplifies quota failure detection logic in the deployment workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/scripts/checkquota.sh Outdated
Comment thread infra/scripts/quota_check_params.sh Outdated
Copilot AI review requested due to automatic review settings June 17, 2026 12:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread infra/main.json
@Roopan-Microsoft Roopan-Microsoft merged commit 7f770ae into dev Jun 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants