Skip to content

Promote uv.lock to stable - #1853

Open
Ryan Brandenburg (ryanbrandenburg) wants to merge 1 commit into
mainfrom
rybrande/uv_lock_promotion
Open

Promote uv.lock to stable#1853
Ryan Brandenburg (ryanbrandenburg) wants to merge 1 commit into
mainfrom
rybrande/uv_lock_promotion

Conversation

@ryanbrandenburg

Copy link
Copy Markdown
Contributor

The telemetry for this detector is looking good so let's promote it from experimental to stable. This will turn it on-by-default and increase the # of components that are detected in any repository that uses uv by default.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes the UvLockComponentDetector from experimental to stable by removing its experiment-based rollout and marking it as a non-experimental detector, making it enabled by default in the orchestrator.

Changes:

  • Removed the UvLockDetectorExperiment configuration and its orchestrator test coverage.
  • Updated UvLockComponentDetector to no longer implement IExperimentalDetector, and adjusted detector registration tests accordingly.
  • Updated detector documentation to reflect stable status (and minor formatting cleanup).
Show a summary per file
File Description
test/Microsoft.ComponentDetection.Orchestrator.Tests/Experiments/UvLockDetectorExperimentTests.cs Removes tests for the uv experiment configuration since the experiment is being retired.
test/Microsoft.ComponentDetection.Detectors.Tests/ComponentDetectorTests.cs Updates assertion to ensure UvLockComponentDetector is not experimental.
src/Microsoft.ComponentDetection.Orchestrator/Extensions/ServiceCollectionExtensions.cs Removes DI registration for the uv experiment configuration.
src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/UvLockDetectorExperiment.cs Removes the uv experiment configuration implementation.
src/Microsoft.ComponentDetection.Detectors/uv/UvLockComponentDetector.cs Drops IExperimentalDetector implementation to make the detector stable/on-by-default.
docs/detectors/uv.md Minor formatting change in the uv detector docs.
docs/detectors/README.md Updates the uv detector status from Experimental to Stable.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 0
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants