krb5: backport upstream SPNEGO mechListMIC parsing fix (ticket 9183)#17784
Open
apurvparekh30 wants to merge 2 commits into
Open
krb5: backport upstream SPNEGO mechListMIC parsing fix (ticket 9183)#17784apurvparekh30 wants to merge 2 commits into
apurvparekh30 wants to merge 2 commits into
Conversation
Azure Linux 3.0 ships krb5 1.21.3, whose get_negTokenResp() looks for the SPNEGO mechListMIC field with ASN.1 context tag [4] (0xA4) instead of the correct [3] (0xA3). This was introduced upstream by commit fdceb225 and breaks SPNEGO MIC verification on the negTokenResp path (notably NTLM-over- SPNEGO authentication to Windows hosts). Backport upstream fix krb5 commit 942c503 (ticket 9183), which corrects the tag and restores the t_spnego.c reselection regression test. Bump release 4 -> 5. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
krb5 is a toolchain package, so bumping its Release requires updating the x86_64 and aarch64 toolchain and pkggen_core manifests to reference the new -5 RPM filenames. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
04df8dc to
56007b6
Compare
KavyaSree2610
approved these changes
Jun 24, 2026
KavyaSree2610
left a comment
There was a problem hiding this comment.
Buddy build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1145800&view=results
The changes looks good to me except for the circular dependency check which is failing(but expected to fail since its trying to download a package version which is not yet available on pmc)
|
|
||
| %changelog | ||
| * Tue Jun 23 2026 Apurv Parekh <apurvparekh@microsoft.com> - 1.21.3-5 | ||
| - Backport upstream fix for SPNEGO mechListMIC parsing (krb5 commit 942c503, ticket 9183) |
There was a problem hiding this comment.
Suggested change
| - Backport upstream fix for SPNEGO mechListMIC parsing (krb5 commit 942c503, ticket 9183) | |
| - Backport upstream fix for SPNEGO mechListMIC parsing (krb5 commit 942c503, ticket 9183) | |
jslobodzian
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Merge Checklist
*-staticsubpackages, etc.) have had theirReleasetag incremented.*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
https://microsoft.visualstudio.com/OS/_workitems/edit/62817258
Azure Linux 3.0 ships krb5 1.21.3-4, whose
get_negTokenResp()parses the SPNEGOmechListMICfield with the wrong ASN.1 context tag —[4](0xA4) instead of the correct[3](0xA3). Per RFC 4178NegTokenResp,mechListMICis[3](andget_negTokenInit()already uses[3]correctly). The bug was introduced upstream by commitfdceb225.As a result the acceptor/initiator fails to read the
mechListMICin anegTokenResp, breaking SPNEGO MIC verification on that path. This is observable when authenticating NTLM-over-SPNEGO to Windows hosts (e.g. PowerShell/WinRM remoting from an Azure Linux container viagss-ntlmssp), where the MIC exchange is required.This PR backports the upstream fix krb5 commit
942c503(ticket 9183,target_version: 1.21-next), which corrects the tag and restores thet_spnego.creselection regression test.Change Log
SPECS/krb5/krb5-fix-SPNEGO-mechListMIC-parsing.patch(full upstream commit942c503, code fix + regression test).krb5.spec: addPatch3, bumpRelease4 → 5, add%changelogentry.toolchain_{x86_64,aarch64}.txtandpkggen_core_{x86_64,aarch64}.txtmanifests to the new1.21.3-5RPM filenames (krb5 is a toolchain package).Sourcefiles changed, sokrb5.signatures.jsonis unchanged.Does this affect the toolchain?
YES — krb5 is a toolchain package. No source/dependency changes, but its
Releasebump (4 → 5) requires the toolchain and pkggen_core package manifests (x86_64 + aarch64) to be updated to the new RPM filenames, which this PR does.Associated issues
Test Methodology
%autosetup -p1); the restoredt_spnego.creselection test runs under%check(make check).