Ignore Enter Key for 50ms When Showing New View in Attended Installer#17781
Open
chriso-ms wants to merge 2 commits into
Open
Ignore Enter Key for 50ms When Showing New View in Attended Installer#17781chriso-ms wants to merge 2 commits into
chriso-ms wants to merge 2 commits into
Conversation
microsoft-github-policy-service
Bot
added
Tools
3.0-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the ISO attended installer from a USB drive on a computer, the Enter key somehow stays buffered or gets repeated and the terminal installer automatically selects the first option and jumps to the next screen. The problem is also seen when trying to go backwards resulting in failure to return to the previous screen (select Back, previous view selects Next and the current view comes back).
This issue is not seen when mounting the installer as a virtual USB to install on a server.
When using a USB stick, there is also a risk of the USB getting corrupted as it shows up as /dev/sda, and the installer automatically selects the USB stick as the target and jumps over the screen. During testing, I could not see the Disk selection screen and would end up inadvertently trying to install on it.
Adding a 50ms ignore interval for the Enter key when switching views resolves the issue. I did not see an option in the tcell library to filter out repeated keys. If there's a better way to resolve this please let me know!