Skip to content

feat: add mlnx-ofa_kernel kernel module#17780

Open
ellie-di wants to merge 1 commit into
4.0from
edehghani/kmod-mlnx-ofa_kernel
Open

feat: add mlnx-ofa_kernel kernel module#17780
ellie-di wants to merge 1 commit into
4.0from
edehghani/kmod-mlnx-ofa_kernel

Conversation

@ellie-di

Copy link
Copy Markdown
Contributor

Adds NVIDIA/Mellanox OFED kernel modules (mlnx-ofa_kernel 26.04) as a kernel subpackage, providing InfiniBand, Ethernet (mlx5), RDMA, and IPoIB driver support. This follows the established kmod framework pattern (similar to nvidia-open).

Copilot AI review requested due to automatic review settings June 22, 2026 20:11
@ellie-di ellie-di requested a review from a team as a code owner June 22, 2026 20:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds NVIDIA/Mellanox OFED kernel modules (mlnx-ofa_kernel 26.04) as a kernel subpackage, providing InfiniBand, Ethernet (mlx5), RDMA, and IPoIB driver support for x86_64 and aarch64. It follows the established kernel kmod framework — phase-based .inc files (package/prep/build/install/files) injected at # AZL-KMOD-*-ANCHOR sentinels via overlays — mirroring the existing nvidia-open kmod. It also ships a -devel subpackage (headers, compat shims, Module.symvers) for out-of-tree consumers.

Changes:

  • New phase-based include kmod-mlnx-ofa_kernel.inc defining the kmod + kmod-devel subpackages and their prep/build/install/files logic (extracts the inner SRPM tarball from the MLNX_OFED_SRC bundle, builds against the just-built kernel, snapshots/restores modules.*, strips .BTF, stages a devel tree).
  • kernel.comp.toml overlays register the OFED source bundle + .inc (Source6100/6101), inject the five kmod phases at the anchors, bump azl_pkgrelease 5→6, and prepend a changelog entry; new defines mlnx_ofa_version/mlnx_ofa_release/mlnx_ofa_bundle_release.
  • Regenerated rendered artifacts (kernel.spec, kernel.azl.macros, sources) and refreshed locks/kernel.lock.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
base/comps/kernel/kmod-mlnx-ofa_kernel.inc New phase-based kmod include with build/install/devel-staging shell logic; header comment has two minor inaccuracies.
base/comps/kernel/kernel.comp.toml Adds OFED source-file, defines, source/phase-injection overlays, release bump, and changelog entry (weekday typo).
specs/k/kernel/kmod-mlnx-ofa_kernel.inc Rendered copy of the new include.
specs/k/kernel/kernel.spec Rendered spec with the five phase includes and changelog entry (weekday typo mirrored).
specs/k/kernel/kernel.azl.macros Generated macros: bumped azl_pkgrelease, added mlnx_ofa_* defines.
specs/k/kernel/sources Adds SHA512 for the MLNX_OFED_SRC bundle.
locks/kernel.lock Updated input fingerprint for the component config change.

Comment thread base/comps/kernel/kernel.comp.toml Outdated
Comment thread specs/k/kernel/kernel.spec Outdated
Comment thread base/comps/kernel/kmod-mlnx-ofa_kernel.inc Outdated
@ellie-di ellie-di changed the title Add mlnx-ofa_kernel kernel module package feat: mlnx-ofa_kernel kernel module Jun 23, 2026
Copilot AI review requested due to automatic review settings June 23, 2026 18:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Comment thread specs/k/kernel/kmod-mlnx-ofa_kernel.inc Outdated
Comment on lines +1 to +10
# kmod-mlnx-ofa.inc — NVIDIA / Mellanox OFED kernel modules (mlnx-ofa_kernel)
#
# Phases: package, prep, build, install, files
# Activated by: setting _kmod_phase + _kmod_name globals and including this
# file from kernel.comp.toml overlays.
#
# Requires these defines/sources in kernel.spec (injected via comp.toml overlays):
# mlnx_ofa_version — driver tag (e.g. 26.04)
# mlnx_ofa_release — vendor release stamp (e.g. OFED.26.04.0.8.5.1)
# SOURCE6100 — mlnx-ofa_kernel-%{mlnx_ofa_version}.tgz
Comment thread base/comps/kernel/kernel.comp.toml Outdated
Comment thread specs/k/kernel/kernel.spec Outdated

# AZL-KMOD-FILES-ANCHOR — do not remove (kmod overlays chain here)
%changelog
* Tue Jun 10 2026 Elaheh Dehghani <edehghani@microsoft.com> - 6.18.31-1.6
@ellie-di ellie-di changed the title feat: mlnx-ofa_kernel kernel module feat: add mlnx-ofa_kernel kernel module Jun 23, 2026
@ellie-di ellie-di force-pushed the edehghani/kmod-mlnx-ofa_kernel branch from 193a051 to 4b6885d Compare June 23, 2026 19:45
Copilot AI review requested due to automatic review settings June 23, 2026 20:16
@ellie-di ellie-di force-pushed the edehghani/kmod-mlnx-ofa_kernel branch from 4b6885d to cf0a796 Compare June 23, 2026 20:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

# AZL-KMOD-BUILD-ANCHOR"""

[[components.kernel.overlays]]
description = "Run mlnx-ofa_kernel kmod 'install' phase — make install_modules into /lib/modules/<KVERREL>/extra/mlnx-ofa"
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

📄❌ Rendered specs are out of date

FIX: — run this and commit the result:

azldev component render -a --clean-stale

Or download the fix patch and apply it:

gh run download 28064770816 -R microsoft/azurelinux -n rendered-specs-patch
git apply rendered-specs.patch
Category Count
Content diffs 0
Extra files (untracked) 23
Missing files (deleted) 72

Files to add

These files are produced by azldev component render but are missing from your branch. Add them.

  • specs/a/ant-contrib/RENDER_FAILED
  • specs/a/antlr/RENDER_FAILED
  • specs/a/apache-commons-cli/RENDER_FAILED
  • specs/a/apache-commons-codec/RENDER_FAILED
  • specs/a/apache-commons-exec/RENDER_FAILED
  • specs/a/apache-commons-io/RENDER_FAILED
  • specs/a/apache-commons-parent/RENDER_FAILED
  • specs/b/beust-jcommander/RENDER_FAILED
  • specs/b/bsf/RENDER_FAILED
  • specs/i/icu4j/RENDER_FAILED
  • specs/j/jaxen/RENDER_FAILED
  • specs/j/jboss-parent/RENDER_FAILED
  • specs/j/jdom/RENDER_FAILED
  • specs/j/jline/RENDER_FAILED
  • specs/j/jsch/RENDER_FAILED
  • specs/l/log4j/RENDER_FAILED
  • specs/m/maven-antrun-plugin/RENDER_FAILED
  • specs/m/maven-archiver/RENDER_FAILED
  • specs/m/maven-assembly-plugin/RENDER_FAILED
  • specs/m/maven-shade-plugin/RENDER_FAILED
  • specs/m/mojo-parent/RENDER_FAILED
  • specs/m/msv/RENDER_FAILED
  • specs/p/plexus-interactivity/RENDER_FAILED

Files to remove

These files are in your branch but are not produced by render. Remove them.

  • specs/a/ant-contrib/ant-contrib-antservertest.patch
  • specs/a/ant-contrib/ant-contrib-java-8.patch
  • specs/a/ant-contrib/ant-contrib.spec
  • specs/a/ant-contrib/sources
  • specs/a/antlr/antlr-2.7.7-configure-c99.patch
  • specs/a/antlr/antlr-2.7.7-newgcc.patch
  • specs/a/antlr/antlr-build.xml
  • specs/a/antlr/antlr.spec
  • specs/a/antlr/generate-tarball.sh
  • specs/a/antlr/sources
  • specs/a/apache-commons-cli/apache-commons-cli.spec
  • specs/a/apache-commons-cli/sources
  • specs/a/apache-commons-codec/apache-commons-codec.spec
  • specs/a/apache-commons-codec/aspell-mail.txt
  • specs/a/apache-commons-codec/sources
  • specs/a/apache-commons-exec/apache-commons-exec.spec
  • specs/a/apache-commons-exec/sources
  • specs/a/apache-commons-io/apache-commons-io.spec
  • specs/a/apache-commons-io/sources
  • specs/a/apache-commons-parent/apache-commons-parent.spec
  • specs/a/apache-commons-parent/sources
  • specs/b/beust-jcommander/0001-ParseValues-NullPointerException-patch.patch
  • specs/b/beust-jcommander/beust-jcommander.spec
  • specs/b/beust-jcommander/generate-tarball.sh
  • specs/b/beust-jcommander/sources
  • specs/b/bsf/bsf-pom.xml
  • specs/b/bsf/bsf.spec
  • specs/b/bsf/build-file.patch
  • specs/b/bsf/build.properties.patch
  • specs/b/bsf/sources
  • specs/i/icu4j/icu4j.spec
  • specs/i/icu4j/sources
  • specs/j/jaxen/jaxen.spec
  • specs/j/jaxen/sources
  • specs/j/jboss-parent/cc0-1.0.txt
  • specs/j/jboss-parent/jboss-parent.spec
  • specs/j/jboss-parent/sources
  • specs/j/jdom/CVE-2021-33813.patch
  • specs/j/jdom/jdom-1.1-OSGiManifest.patch
  • specs/j/jdom/jdom-1.1.3.pom
  • specs/j/jdom/jdom-crosslink.patch
  • specs/j/jdom/jdom.spec
  • specs/j/jdom/sources
  • specs/j/jline/0001-Load-native-library-form-usr-lib-jline.patch
  • specs/j/jline/0002-Remove-optional-dependency-on-universalchardet.patch
  • specs/j/jline/jline.spec
  • specs/j/jline/sources
  • specs/j/jsch/MANIFEST.MF
  • specs/j/jsch/jsch.spec
  • specs/j/jsch/plugin.properties

… and 22 more file(s).

@ellie-di ellie-di force-pushed the edehghani/kmod-mlnx-ofa_kernel branch from cf0a796 to c87c294 Compare June 23, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants