fix(systemd): set default llmnr support to disabled#17095
Open
ddstreet wants to merge 3 commits intomicrosoft:tomls/base/mainfrom
Open
fix(systemd): set default llmnr support to disabled#17095ddstreet wants to merge 3 commits intomicrosoft:tomls/base/mainfrom
ddstreet wants to merge 3 commits intomicrosoft:tomls/base/mainfrom
Conversation
ddstreet
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Azure Linux systemd component configuration to disable LLMNR by default at build time, and refreshes the corresponding rendered spec + lock fingerprint.
Changes:
- Change systemd meson default from
-Ddefault-llmnr=resolveto-Ddefault-llmnr=noin the rendered spec. - Add a component overlay to enforce the LLMNR default in
systemd.comp.toml. - Update the
systemd.lockinput fingerprint to reflect the component definition change.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| specs/s/systemd/systemd.spec | Rendered spec updated to bump release and set -Ddefault-llmnr=no (plus new rpmautospec changelog entry). |
| locks/systemd.lock | Updates input-fingerprint to match the component definition inputs. |
| base/comps/systemd/systemd.comp.toml | Adds a spec-search-replace overlay to force -Ddefault-llmnr=no. |
reubeno
approved these changes
May 8, 2026
christopherco
requested changes
May 9, 2026
Collaborator
christopherco
left a comment
christopherco
left a comment
There was a problem hiding this comment.
LGTM in general. There's a debate going on about the rendered changelog message. Holding off on this until we sort that changelog message out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change the default llmnr to 'no' (disabled)