Skip to content

Conversation

@Kanishk-Bansal
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

NO

Associated issues
  • N/A
Links to CVEs
Test Methodology

@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner January 6, 2026 17:53
@Kanishk-Bansal Kanishk-Bansal added security CVE-fixed-by-upgrade CVE fixed by package upgrade labels Jan 6, 2026
@Kanishk-Bansal
Copy link
Contributor Author

Source Tarball - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1019826&view=results
Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1020127&view=results
jedisct1/libsodium@5106e05 Commit shows that CVE fix has been taken to 1.0.18-FINAL tarball which was released with the security fix after 1.0.18 as a pointer release.
Updated the tarball and added autoreconf -fiv as previously the build was failing with the error

`time="2026-01-06T17:17:18Z" level=debug msg="+ ./configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --disable-silent-rules --disable-opt"

time="2026-01-06T17:17:18Z" level=debug msg="/var/tmp/rpm-tmp.0cHz2U: line 49: ./configure: No such file or directory"
`

Copy link
Contributor

@mayankfz mayankfz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks fine

@mayankfz mayankfz added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CVE-fixed-by-upgrade CVE fixed by package upgrade main PR Destined for main Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants