Skip to content

Conversation

@v-aaditya
Copy link
Contributor

@v-aaditya v-aaditya commented Dec 24, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
  • Upgrade perl-Alien-pkgconf to version 0.21
  • Removed dependency on external modules perl(FFI::Platypus) and perl(Test2::Tools::Process) to correct install failure of the RPM package.
Build/Dependency Information

Please build the following packages with "perl-Alien-pkgconf" -
"perl-Unicode-LineBreak sombok libthai perl-MIME-Charset perl-Encode-EUCJPASCII libdatrie perl-Term-Size-Perl perl-Term-Size-Any perl-Test2-Suite perl-Module-Pluggable perl-IPC-Run3 perl-App-FatPacker perl-Importer perl-Scope-Guard perl-Sub-Info perl-Test-Exit perl-Term-Table perl-Return-MultiLevel perl-Data-Munge perl-Scope-Upper perl-FFI-CheckLib perl-Class-Inspector perl-File-ShareDir perl-File-ShareDir-Install"

Change Log
  • modified: cgmanifest.json
  • modified: SPECS-EXTENDED/perl-FFI-CheckLib/perl-FFI-CheckLib.spec
  • modified: SPECS-EXTENDED/perl-Alien-pkgconf/perl-Alien-pkgconf.spec
  • modified: SPECS-EXTENDED/perl-Alien-pkgconf/perl-Alien-pkgconf.signatures.json
Does this affect the toolchain?

NO

Test Methodology
image image
  • Uninstallation Check
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 24, 2025
@v-aaditya
Copy link
Contributor Author

v-aaditya commented Dec 24, 2025

Please build the following packages with "perl-Alien-pkgconf" -
"perl-Unicode-LineBreak sombok libthai perl-MIME-Charset perl-Encode-EUCJPASCII libdatrie perl-Term-Size-Perl perl-Term-Size-Any perl-Test2-Suite perl-Module-Pluggable perl-IPC-Run3 perl-App-FatPacker perl-Importer perl-Scope-Guard perl-Sub-Info perl-Test-Exit perl-Term-Table perl-Return-MultiLevel perl-Data-Munge perl-Scope-Upper perl-FFI-CheckLib perl-Class-Inspector perl-File-ShareDir perl-File-ShareDir-Install"

@v-aaditya v-aaditya marked this pull request as ready for review December 24, 2025 11:48
@v-aaditya v-aaditya requested review from a team as code owners December 24, 2025 11:48
@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 24, 2025

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Removal of Platypus dependency is valid since we don't have the package yet and Checklib doesn't directly depend on the Platypus. Checklib provides a find_lib function that will return the full path to the found dynamic library, which can be feed directly
into FFI::Platypus or FFI::Raw

Platypus is a Perl library for creating interfaces to machine code libraries
written in languages like C, C++, Fortran, Rust, Pascal..

There is test failure in the dependency package which is not related to this package and need to be fixed separately.

@sandeepkarambelkar
Copy link
Contributor

@v-aaditya , can you update install verification for these RPMs since that never got executed due to test failure?

@v-aaditya v-aaditya changed the title Upgrade perl-Alien-pkgconf to version 0.21 and resolved perl-FFI-Check install failure Upgrade perl-Alien-pkgconf to version 0.21 and resolved perl-FFI-CheckLib install failure Dec 24, 2025
@v-aaditya
Copy link
Contributor Author

@v-aaditya , can you update install verification for these RPMs since that never got executed due to test failure?

Installation and Uninstallation check for "perl-Alien-pkgconf" and "perl-FFI-CheckLib" packages -
image
image

  • Uninstallation Check
image

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build has few failures which are due to dependent packages, perl-Return-MultiLevel. Minor version upgrade to extended repo package and small correction in another package. The license for upstream source is https://github.com/PerlAlien/Alien-pkgconf/blob/main/LICENSE, which GPL1+ hence GPL3 is acceptable. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants