-
Notifications
You must be signed in to change notification settings - Fork 602
Upgrade perl-Alien-pkgconf to version 0.21 and resolved perl-FFI-CheckLib install failure #15388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Upgrade perl-Alien-pkgconf to version 0.21 and resolved perl-FFI-CheckLib install failure #15388
Conversation
…kLib install failure
|
Please build the following packages with "perl-Alien-pkgconf" - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Removal of Platypus dependency is valid since we don't have the package yet and Checklib doesn't directly depend on the Platypus. Checklib provides a find_lib function that will return the full path to the found dynamic library, which can be feed directly
into FFI::Platypus or FFI::Raw
Platypus is a Perl library for creating interfaces to machine code libraries
written in languages like C, C++, Fortran, Rust, Pascal..
There is test failure in the dependency package which is not related to this package and need to be fixed separately.
|
@v-aaditya , can you update install verification for these RPMs since that never got executed due to test failure? |
Installation and Uninstallation check for "perl-Alien-pkgconf" and "perl-FFI-CheckLib" packages -
|
kgodara912
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy build has few failures which are due to dependent packages, perl-Return-MultiLevel. Minor version upgrade to extended repo package and small correction in another package. The license for upstream source is https://github.com/PerlAlien/Alien-pkgconf/blob/main/LICENSE, which GPL1+ hence GPL3 is acceptable. LGTM.



Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Build/Dependency Information
Please build the following packages with "perl-Alien-pkgconf" -
"perl-Unicode-LineBreak sombok libthai perl-MIME-Charset perl-Encode-EUCJPASCII libdatrie perl-Term-Size-Perl perl-Term-Size-Any perl-Test2-Suite perl-Module-Pluggable perl-IPC-Run3 perl-App-FatPacker perl-Importer perl-Scope-Guard perl-Sub-Info perl-Test-Exit perl-Term-Table perl-Return-MultiLevel perl-Data-Munge perl-Scope-Upper perl-FFI-CheckLib perl-Class-Inspector perl-File-ShareDir perl-File-ShareDir-Install"
Change Log
Does this affect the toolchain?
NO
Test Methodology
Local build was successful.
License check script shows no license warning.
Build logs
perl-FFI-CheckLib-0.31-2.azl3.src.rpm.test.log
perl-Alien-pkgconf-0.21-1.azl3.src.rpm.log
perl-FFI-CheckLib-0.31-2.azl3.src.rpm.log
Installation Check