Upgrade nodejs to 24.12.0 and add fix for runtime internationalization support #15385

sandeepkarambelkar · 2025-12-24T04:53:01Z

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

Summary

Upgrade nodejs to 24.12.0 and add fix for runtime internationalization support

Change Log

nodejs is upgraded to 24.12.1

Does this affect the toolchain?

NO

Test Methodology

Pipeline build id: 1011745

Copilot

Pull request overview

This PR upgrades Node.js from version 20.14.0 to 24.11.1 and adds runtime internationalization (i18n) support by incorporating ICU data files. The upgrade removes multiple CVE patches that are resolved in the new version.

Key changes:

Upgrade to Node.js 24.11.1 with npm 11.6.2
Add full internationalization support via ICU 77.1 data files with a new nodejs-full-i18n subpackage
Remove 12 CVE patches (CVE-2024-21538, CVE-2025-23083, CVE-2025-22150, CVE-2025-23085, CVE-2024-22020, CVE-2025-27516, CVE-2025-47279, CVE-2025-23165, CVE-2025-23166, CVE-2025-5222) that are resolved in the new version

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

File	Description
SPECS/nodejs/nodejs.spec	Main spec file upgraded to version 24.11.1-1, adds ICU support macros, new full-i18n subpackage, downloads ICU data files, and removes resolved CVE patches
SPECS/nodejs/nodejs.signatures.json	Updates signatures for the new Node.js tarball and adds signatures for the new ICU data files and test script
SPECS/nodejs/btest402.js	New test script to validate ECMAScript 402 internationalization support
SPECS/nodejs/CVE-*.patch	Multiple CVE patch files removed as they are resolved in Node.js 24.11.1

Comments suppressed due to low confidence (1)

SPECS/nodejs/nodejs.spec:199

Multiple changelog entries have dates in the future (2025), including entries dated November 2025, May 2025, March 2025, and February 2025. These dates should be corrected to 2024 or the actual dates when these changes were made. This affects lines 180, 183, 186, 189, 192, 196, and 199.

* Fri Nov 07 2025 Azure Linux Security Servicing Account <azurelinux-security@microsoft.com> - 20.14.0-10
- Patch for CVE-2025-5222

* Tue May 27 2025 Aninda Pradhan <v-anipradhan@microsoft.com> - 20.14.0-9
- Patch CVE-2025-23165, CVE-2025-23166

* Wed May 21 2025 Aninda Pradhan <v-anipradhan@microsoft.com> - 20.14.0-8
- Patch CVE-2025-47279

* Mon Mar 10 2025 Sandeep Karambelkar <skarambelkar@microsoft.com> - 20.14.0-7
- Patch CVE-2025-27516

* Wed Feb 12 2025 Kevin Lockwood <v-klockwood@microsoft.com> - 20.14.0-6
- Patch CVE-2020-28493
- Patch CVE-2024-34064

* Tue Feb 11 2025 Kanishk Bansal <kanbansal@microsoft.com> - 20.14.0-5
- Patch CVE-2025-22150, CVE-2025-23085, CVE-2024-22020, CVE-2024-22195

* Mon Jan 27 2025 Sumedh Sharma <sumsharma@microsoft.com> - 20.14.0-4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SPECS/nodejs/btest402.js

SPECS/nodejs/nodejs.spec

SPECS/nodejs/nodejs.signatures.json

SPECS/nodejs/btest402.js

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SPECS/nodejs/nodejs.spec

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sandeepkarambelkar · 2025-12-24T10:59:31Z

Buddy Build after integrating review comments from github copilot.

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011912&view=results

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-24T11:00:01Z

SPECS/nodejs/btest402.js

+        for ( var n=0; n<locs.length; n++ ) {
+            var loc = locs[n];
+            var lsummary = summary[loc] = {};
+


Trailing whitespace detected on this line. This should be removed to maintain code cleanliness.

Suggested change

Copilot · 2025-12-24T11:00:01Z

SPECS/nodejs/btest402.js

+    console.log("----------------");
+    console.log( "SUMMARY:" +  stxt );
+}
+


Trailing whitespace detected on this line. This should be removed to maintain code cleanliness.

Suggested change

Copilot · 2025-12-24T11:00:02Z

SPECS/nodejs/btest402.js

+    console = { log: print };
+    console.log("Now you have console.log.");
+}
+


Trailing whitespace detected on this line. This should be removed to maintain code cleanliness.

Copilot · 2025-12-24T11:00:02Z

SPECS/nodejs/btest402.js

+    var stxt = "";
+    if( summary.haveIntl ) {
+        console.log("* You have the 'Intl' object. Congratulations! You have the possibility of being EcmaScript 402 compliant.");
+        stxt += "Have Intl, ";


Trailing whitespace detected on this line. This should be removed to maintain code cleanliness.

SPECS/nodejs/nodejs.spec

Copilot · 2025-12-24T11:00:03Z

SPECS/nodejs/nodejs.spec

+
 %check
+# Make sure i18n support is working
+NODE_PATH=%{buildroot}%{_prefix}/lib/node_modules:%{buildroot}%{_prefix}/lib/node_modules/npm/node_modules LD_LIBRARY_PATH=%{buildroot}%{_libdir} %{buildroot}/%{_bindir}/node --icu-data-dir=%{buildroot}%{icudatadir} %{SOURCE3}


The test command in the check section has a very long line that would benefit from being split across multiple lines for better readability. Consider using line continuation (backslash) to break this command into multiple lines.

Copilot · 2025-12-24T11:00:03Z

SPECS/nodejs/btest402.js

+// for a complete test, see http://test262.ecmascript.org
+//
+// Usage: node btest402.js
+


Trailing whitespace detected on this line. This should be removed to maintain code cleanliness.

sandeepkarambelkar added 4 commits December 9, 2025 12:59

nodejs 24 upgrade

ca3ae96

Merge branch '3.0-dev' into skarambelkar-nodejs-24upgrade

051803c

Update CVEs and fix for internationalization support

d1d0d9d

Merge branch '3.0-dev' into skarambelkar-nodejs-24upgrade

228d7ce

sandeepkarambelkar requested a review from a team as a code owner December 24, 2025 04:53

sandeepkarambelkar requested a review from Copilot December 24, 2025 04:53

microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 24, 2025

Copilot started reviewing on behalf of sandeepkarambelkar December 24, 2025 04:53 View session

Copilot AI reviewed Dec 24, 2025

View reviewed changes

sandeepkarambelkar added 2 commits December 24, 2025 05:00

Update latest LTS version

6509651

Update nodejs 24.12 signature

633e9e9

sandeepkarambelkar changed the title ~~Upgrade nodejs to 24.11.1 and add fix for runtime internationalization support~~ Upgrade nodejs to 24.12.0 and add fix for runtime internationalization support Dec 24, 2025

sandeepkarambelkar requested a review from Copilot December 24, 2025 10:41

Copilot started reviewing on behalf of sandeepkarambelkar December 24, 2025 10:42 View session

Copilot AI reviewed Dec 24, 2025

View reviewed changes

SPECS/nodejs/nodejs.spec Outdated Show resolved Hide resolved

SPECS/nodejs/nodejs.spec Outdated Show resolved Hide resolved

sandeepkarambelkar and others added 2 commits December 24, 2025 16:24

Apply suggestions from code review from copilot

9f21324

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update SPECS/nodejs/nodejs.spec to fix version in changelog entry

ffd769e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sandeepkarambelkar requested a review from Copilot December 24, 2025 10:56

Copilot started reviewing on behalf of sandeepkarambelkar December 24, 2025 10:57 View session

sandeepkarambelkar and others added 2 commits December 24, 2025 16:27

Update SPECS/nodejs/nodejs.signatures.json fix json formatting

72e1c20

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix file signatures

fbd9da1

Copilot AI reviewed Dec 24, 2025

View reviewed changes

Upgrade nodejs to 24.12.0 and add fix for runtime internationalization support #15385

Are you sure you want to change the base?

Upgrade nodejs to 24.12.0 and add fix for runtime internationalization support #15385

Uh oh!

Conversation

sandeepkarambelkar commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

Summary

Change Log

Does this affect the toolchain?

Test Methodology

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sandeepkarambelkar commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sandeepkarambelkar commented Dec 24, 2025 •

edited

Loading

sandeepkarambelkar commented Dec 24, 2025 •

edited

Loading