Skip to content

Conversation

@v-aaditya
Copy link
Contributor

@v-aaditya v-aaditya commented Dec 23, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
  • Added "llhttp" package version 9.3.0 to SPECS-EXTENDED
  • Which results in successful build of "tang" package
Build/Dependency Information

kindly build below package with "llhttp" and "tang" -
"jose"

Change Log
  • modified: cgmanifest.json
  • new file: SPECS-EXTENDED/llhttp/llhttp.spec
  • new file: SPECS-EXTENDED/llhttp/llhttp.signatures.json
  • modified: LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
  • modified: LICENSES-AND-NOTICES/SPECS/data/licenses.json
Does this affect the toolchain?

NO

Test Methodology
image image
  • Uninstallation Check
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 23, 2025
@v-aaditya v-aaditya marked this pull request as ready for review December 23, 2025 11:52
@v-aaditya v-aaditya requested review from a team as code owners December 23, 2025 11:52
@sandeepkarambelkar
Copy link
Contributor

@v-aaditya
Copy link
Contributor Author

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011910&view=results

Hi Sandeep. The Buddy Build has failed as it needs dependency package "jose". kindly give this as dependency list -
"jose llhttp tang".

@sandeepkarambelkar
Copy link
Contributor

@v-aaditya
Copy link
Contributor Author

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build successful.
Changes LGTM.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build is successful. Spec file matches with upstream Fedora reference. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants