Skip to content

Conversation

@suresh-thelkar
Copy link
Contributor

@suresh-thelkar suresh-thelkar commented Dec 23, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Upgrade irqbalance to 1.9.5

  • SPECS/irqbalance/irqbalance.spec
    Version bumped 1.9.3 → 1.9.5; Release reset 2 → 1.
    Patch0 removed (IRQBALANCE_ARGS) since v1.9.5 defines IRQBALANCE_ARGS="" in irqbalance.env.
    Post-install cleanup to remove upstream default env to avoid duplicate: rm %{buildroot}%

  • {_prefix}/etc/default/irqbalance.env.
    Service unit normalized: EnvironmentFile now points to /etc/sysconfig/irqbalance; upstream/env-prefixed entries removed.

  • SPECS/irqbalance/irqbalance.signatures.json
    Source tarball updated to irqbalance-1.9.5.tar.gz with new SHA256.

  • cgmanifest.json
    Component version and downloadUrl updated to v1.9.5.

Change Log
  • NA
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
  • NA
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 23, 2025
@suresh-thelkar suresh-thelkar marked this pull request as ready for review December 23, 2025 11:02
@suresh-thelkar suresh-thelkar requested a review from a team as a code owner December 23, 2025 11:02
# Normalize unit EnvironmentFile entries
sed -i \
-e 's#^EnvironmentFile=/usr/etc/default/irqbalance\.env#EnvironmentFile=/etc/sysconfig/irqbalance#' \
-e '/^EnvironmentFile=-\${prefix}\/etc\/default\/irqbalance/d' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use # for separators like you did above for consistency and readability.

Copy link
Contributor Author

@suresh-thelkar suresh-thelkar Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PawelWMS, Thanks for your suggestion. Here is what we are doing with the above second sed expression.

The second sed expression at line 41 deletes the following line from irqbalance.service:
EnvironmentFile=-${prefix}/etc/default/irqbalance

Part of Original Snapshot of the service file:
image

We are shipping the RPM with only a single environment file under /etc/sysconfig, so the alternate file is not required. Note that the line starts with a - after =, which indicates an optional (alternate) environment file.

If a customer needs additional environment files, they can still configure them using this syntax in the service file. Therefore, we are removing the alternate EnvironmentFile entry. I hope this approach is okay. Please take a look and let me know in case If I am missing anything.

Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, change looks good.

@suresh-thelkar
Copy link
Contributor Author

One minor suggestion, change looks good.

Thank you very much for the review and approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants