Skip to content

Upgrade ibus-libzhuyin to version 1.10.4 and libpinyin to version 2.10.3 #15375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
v-aaditya wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from
Open

Upgrade ibus-libzhuyin to version 1.10.4 and libpinyin to version 2.10.3 #15375

v-aaditya wants to merge 2 commits into from
+29 −42

Conversation

@v-aaditya
Copy link
Contributor

@v-aaditya v-aaditya commented Dec 23, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary
  • Upgrade ibus-libzhuyin to version 1.10.4
  • Upgrade libpinyin to version 2.10.3 as it was not able to provide 'punct.table' to ibus-libzhuyin which was causing build failures.
Build/Dependency Information

Please build the following packages with "ibus-libzhuyin" package -
"cldr-emoji-annotation kyotocabinet iso-codes libdbusmenu unicode-emoji unicode-ucd ibus libpinyin"

Change Log
  • modified: cgmanifest.json
  • modified: SPECS-EXTENDED/libpinyin/libpinyin.spec
  • modified: SPECS-EXTENDED/libpinyin/libpinyin.signatures.json
  • modified: SPECS-EXTENDED/ibus-libzhuyin/ibus-libzhuyin.spec
  • modified: SPECS-EXTENDED/ibus-libzhuyin/ibus-libzhuyin.signatures.json
Does this affect the toolchain?

NO

Test Methodology
image
  • Uninstallation Check
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 23, 2025
@v-aaditya
Copy link
Contributor Author

v-aaditya commented Dec 23, 2025

Please build the following dependency packages with "ibus-libzhuyin" package -
"cldr-emoji-annotation kyotocabinet iso-codes libdbusmenu unicode-emoji unicode-ucd ibus libpinyin"

@v-aaditya v-aaditya force-pushed the topic_ibus-libzhuyin-3.0 branch from 75b61ea to 5a085d6 Compare December 23, 2025 04:43
@v-aaditya v-aaditya force-pushed the topic_ibus-libzhuyin-3.0 branch from 5a085d6 to 2dfbf1c Compare December 23, 2025 04:51
@v-aaditya v-aaditya marked this pull request as ready for review December 23, 2025 04:58
@v-aaditya v-aaditya requested review from a team as code owners December 23, 2025 04:58
@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 23, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011012&view=results

@v-aaditya
Copy link
Contributor Author

v-aaditya commented Dec 23, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011012&view=results

Buddy Build has passed but with license check warning issue. Addressed the 'libpinyin' license issue. Other license issues are in packages 'kyotocabinet-apidocs' and 'unicode-ucd' which are not related to this package upgrade.

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 23, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011032&view=results

@v-aaditya
Copy link
Contributor Author

v-aaditya commented Dec 23, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011032&view=results

Buddy Build has passed with license check warning issue. Now the license issues are in packages 'kyotocabinet-apidocs' and 'unicode-ucd' which are not related to this package upgrade. PFB screenshot for reference -
image

sandeepkarambelkar
sandeepkarambelkar approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy Build Successful.
Changes LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeepkarambelkar sandeepkarambelkar sandeepkarambelkar approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-aaditya @sandeepkarambelkar