-
Notifications
You must be signed in to change notification settings - Fork 602
Update rhino to version 1.7.15.1 #15374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Conversation
Add missing newline at the end of the file.
Buddy Build is Successful. Buddy Build to check the dependent package after fixing rhino - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011876&view=results |
sandeepkarambelkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No any warnings in the build logs.
Buddy Build successful.
Changes LGTM
|
bsf builds successfully after this change. Can you add fix for license issues of bsf in the same PR? ##[warning]License issues found. |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
This is to upgrade the package rhino to version 1.7.15.1
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology