-
Notifications
You must be signed in to change notification settings - Fork 602
Build fix for python-fixtures. #15342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Conversation
|
Buddy Build to verify the build of dependent packages - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011913&view=results |
sandeepkarambelkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy Build successful.
Changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As such changes look fine but check once python-fixtures changes if they are needed or not in regular build path. Also, the dependent packages' buddy build is still failing, are we investigating those failures or those are expected?
|
@kgodara912 , dependent packages failures if any will be addressed as separate PR |
Added additional build requirements for testing.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Build fix for failing python-fixtures. Dependency packages-python-colorama , python-testtools, python-toml , python-tox
Change Log
Does this affect the toolchain?
NO
Test Methodology
-Screenshot of successful build-
