Skip to content

Conversation

@AkarshHCL
Copy link
Contributor

@AkarshHCL AkarshHCL commented Dec 18, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Build fix for failing python-fixtures. Dependency packages-python-colorama , python-testtools, python-toml , python-tox

Change Log
  • SPECS-EXTENDED/python-fixtures/python-fixtures.spec
Does this affect the toolchain?

NO

Test Methodology

-Screenshot of successful build-
image

@AkarshHCL AkarshHCL requested a review from a team as a code owner December 18, 2025 08:16
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 18, 2025
@AkarshHCL AkarshHCL closed this Dec 18, 2025
@AkarshHCL AkarshHCL reopened this Dec 18, 2025
@sandeepkarambelkar
Copy link
Contributor

@AkarshHCL AkarshHCL requested a review from a team as a code owner December 23, 2025 04:52
@sandeepkarambelkar
Copy link
Contributor

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 23, 2025

Buddy Build to verify the build of dependent packages - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011913&view=results

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy Build successful.
Changes LGTM.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As such changes look fine but check once python-fixtures changes if they are needed or not in regular build path. Also, the dependent packages' buddy build is still failing, are we investigating those failures or those are expected?

@sandeepkarambelkar
Copy link
Contributor

@kgodara912 , dependent packages failures if any will be addressed as separate PR

@AkarshHCL AkarshHCL requested a review from kgodara912 December 24, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants