Skip to content

Conversation

@durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented Dec 17, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
  • Upgrade osgi-core to 8.0.0
Change Log
  • SPECS-EXTENDED/osgi-core/osgi-core-build.xml
  • SPECS-EXTENDED/osgi-core/osgi-core.signatures.json
  • SPECS-EXTENDED/osgi-core/osgi-core.spec
  • osgi.core-8.0.0.pom
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx
  • image

@durgajagadeesh durgajagadeesh requested review from a team as code owners December 17, 2025 12:44
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 17, 2025
@durgajagadeesh
Copy link
Contributor Author

This package has been built successfully along with osgi-annotation.
image
-Thank you!

@durgajagadeesh durgajagadeesh marked this pull request as draft December 17, 2025 12:47
@durgajagadeesh durgajagadeesh marked this pull request as ready for review December 17, 2025 12:55
@sandeepkarambelkar
Copy link
Contributor

@sandeepkarambelkar
Copy link
Contributor

@durgajagadeesh There are license check failures. Can you check them?

##[warning]License issues found.
WARN: (osgi-core-javadoc-8.0.0-3.azl3.noarch.rpm) has license warnings:
bad %doc files:
/usr/share/javadoc/osgi-core/legal/ADDITIONAL_LICENSE_INFO
duplicated license files:
/usr/share/javadoc/osgi-core/legal/LICENSE

@sandeepkarambelkar
Copy link
Contributor

@durgajagadeesh
Copy link
Contributor Author

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010278&view=results

Hi @sandeepkarambelkar, buddy build has been completed. Successfully.
-Thank you!

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy Build Successful.
Changes LGTM

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As such package upgrade looks fine. Buddy build is successful. Please address minor nit.

@sandeepkarambelkar
Copy link
Contributor

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 24, 2025

Hi @sandeepkarambelkar, could you please retrigger buddy build once again with run time dependency only with osgi-annotation.
image

@sandeepkarambelkar
Copy link
Contributor

@kgodara912
Copy link
Contributor

Buddy build after latest commit.

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 24, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011878&view=results

Hi @sandeepkarambelkar, I’ve resolved the license warning.

INFO[0004][licensecheck] Search results for (/mnt/vss/_work/1/s/out/RPMS):
WARN: (osgi-compendium-javadoc-7.0.0-2.azl3.noarch.rpm) has license warnings:
bad %doc files:
/usr/share/javadoc/osgi-compendium/legal/ADDITIONAL_LICENSE_INFO
duplicated license files:
/usr/share/javadoc/osgi-compendium/legal/LICENSE

Could you please trigger the buddy build again? Thanks!

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build is successful. Version upgrade in extended repo and fixes for license warnings in both specs. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants