fix: JupyterCodeExecutor temp directory leak (#7217)#7233
Open
paipeline wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: JupyterCodeExecutor temp directory leak (#7217)#7233paipeline wants to merge 1 commit intomicrosoft:mainfrom
paipeline wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…t#7217 - Replace tempfile.mkdtemp() with tempfile.TemporaryDirectory() for proper automatic cleanup - Add cleanup logic in stop() method to prevent temp directory leaks - Ensure user-provided output directories are not cleaned up - Maintain consistency with other CodeExecutor implementations (LocalCommandLineCodeExecutor, DockerCommandLineCodeExecutor, AzureContainerCodeExecutor) The fix prevents accumulation of temporary files and directories when JupyterCodeExecutor is used without specifying an output_dir parameter.
Contributor
|
@paipeline please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7217 —
JupyterCodeExecutorleaks temporary directories because it usestempfile.mkdtemp()without ever cleaning up the created directory.Problem
When no explicit
output_diris provided,JupyterCodeExecutor.__init__callstempfile.mkdtemp()to create a temporary directory. However, this directory is never removed — not on garbage collection, not onstop(), and not on interpreter shutdown. Over time (especially in long-running agent loops), this leaks directories in the system temp folder.Fix
tempfile.mkdtemp()withtempfile.TemporaryDirectory(), storing the object so it can be explicitly cleaned up.stop()method to call.cleanup()on the temporary directory.output_dir, behavior is unchanged (we never delete user-supplied directories).Testing
Existing tests continue to pass. The fix is minimal and scoped to resource cleanup only.