fix(policy): resolve project_root before path-traversal check#895
Open
qorexdevs wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(policy): resolve project_root before path-traversal check#895qorexdevs wants to merge 1 commit intomicrosoft:mainfrom
qorexdevs wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_get_cache_dirpasses an unresolvedproject_roottoensure_path_within, which then resolvescandidateandbase_dirindependently. On Windows,Path.resolve()on an existing path expands 8.3 short names (e.g.RUNNER~1->runneradmin) and may add the\?\extended-length prefix, but on a not-yet-existing path it keeps the original form. Whencandidatedoesn't exist yet (first writer in a concurrent scenario), the two sides resolve to different forms andis_relative_tofails withPathTraversalError.Two changes:
discovery.py: resolveproject_rootonce at the top of_get_cache_dirso the candidate path inherits the long-name formpath_security.py: strip the\?\extended-length prefix inensure_path_withinbefore comparison, since Windowsresolve()adds it inconsistentlyFixes #886
Type of change
Testing
test_unresolved_project_root_does_not_raise) that passes a symlink-indirect project root through_get_cache_dir