Handle OSError when checking file existence for long paths on macOS#880
Closed
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Closed
Handle OSError when checking file existence for long paths on macOS#880Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Jah-yee
requested review from
danielmeppiel and
sergio-sisternes-epam
as code owners
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
On macOS, PATH_MAX is 1023 bytes, so paths longer than that cause OSError [Errno 63] when checking file existence. This PR wraps the path.is_file() check in a try/except to handle this gracefully.
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithRoof
Reference: #848