Add typed repository source inputs and session metadata - #451
Open
Osvaldo Ortega (osortega) wants to merge 4 commits into
Open
Osvaldo Ortega (osortega) wants to merge 4 commits into
Osvaldo Ortega (osortega) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 16, 2026
Osvaldo Ortega (osortega)
marked this pull request as ready for review
September 17, 2026 18:06
Osvaldo Ortega (osortega)
requested review from
Connor Peet (connor4312) and
roblourens
as code owners
September 17, 2026 18:06
Use optional repositorySource and repositoryRevision values in the existing session config flow. Remove the unreleased descriptor, key mapping, exports, and generator registrations while retaining host-owned preparation, lifecycle, and recovery semantics. Update generated mirrors, documentation, and shared wire and SDK coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 79731f48-d288-483f-8809-136aa141d1eb
Replace repeated configuration rules with links to the shared schema documentation and keep progress guidance operation-neutral. Retain the normative specification and the source/directory, readiness, and disposal safeguards. Regenerate SDK comments and schema descriptions without changing declarations or wire structure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 79731f48-d288-483f-8809-136aa141d1eb
Move repository source and revision out of provider configuration into existing request types and immutable session metadata. Advertise source and revision support explicitly through agent capabilities and keep the preparation lifecycle unchanged. Regenerate all SDKs and schemas, and cover typed requests, capability discovery, and recoverable state in shared wire fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 79731f48-d288-483f-8809-136aa141d1eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make repository intent a first-class AHP contract, separate from provider configuration and resolved filesystem locations:
{ "channel": "ahp-session:/new", "repositorySource": "https://example.org/team/project.git", "repositoryRevision": "main", "config": { "mode": "interactive" } }repositorySource: URIandrepositoryRevision: stringfields toCreateSessionParams,ResolveSessionConfigParams, andSessionConfigCompletionsParams.SessionMetadata, inherited bySessionStateandSessionSummary. Hosts preserve the requested intent from Creating through Ready/Failed, including reconnect and listing; resolved directories remain separate.AgentCapabilities.repositorySource: absent means unsupported,{}supports source-based creation, and{ "revision": true }also supports an explicit revision.configfor provider-specific settings. There are no repository config keys, property-name mappings, or repository descriptors inSessionConfigSchema.The source URI identifies what to prepare, not a checkout identity. One source may produce multiple directories or different worktrees across sessions. Source and nonempty
workingDirectoriesare mutually exclusive on creation; config queries may include an existingworkingDirectoryas context.Protocol revision for downstream synchronization:
fa44ef3fae7c4750012024c106b70577e7a027c4.Public client counterpart: microsoft/vscode#336361.
Validation of this typed-field revision
npm test: 460 tests passed, including typecheck, lint, release/changelog and schema checks, with 100% reducer coverage.ahp-typesunit/corpus/doc tests andcargo check --locked --manifest-path clients/rust/Cargo.toml -p ahp --libpassed.go test ./...passed. SwiftTypesRoundTripFixtureTestsand KotlinRoundTripCorpusTestpassed. The targeted .NETTypesRoundTripFixturesrun passed 50 tests.Reading order
Limits
These are protocol, generated-client, wire and in-memory SDK checks, not live host/client interoperability evidence. Generated types do not enforce URI policy, authorization, lifecycle ordering or cleanup; concrete hosts and clients must enforce the contract. No application, daemon, UI or end-to-end scenario was launched for this revision.
Clients and hosts using the earlier unreleased config-based drafts need coordinated updates. Earlier manual testing, CI and independent reviews apply only to their original revisions; no new live rollout, released-binary compatibility or independent review is claimed here.