Repository navigation
Python: Make response overview examples runnable - #9617
BlueRaddish wants to merge 1 commit into
Conversation
AI-assisted with OpenAI Codex.
|
/review |
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): d6cfbe00c854
Model: gpt-5.6-sol
Overview
This PR replaces non-runnable Ellipsis placeholders in two class docstrings with concrete response updates that exercise aggregation and serialization. The imported symbols are valid public exports, the examples match the aggregation contracts, and existing tests cover the relevant text, metadata, and round-trip behavior; no publishable defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
|
BlueRaddish, this pull request is waiting on your response. If there is no further activity within 4 days, it will be closed automatically. (This is an automated message.) |
AI-assisted with OpenAI Codex.
… notes Accept legacy positive cache_max_size values with a deprecation warning, without restoring initialized-session caching. Keep per-invocation security isolation and the approved 1.5.0 version, document the compatibility behavior and remaining lifecycle migration, and extend real-protocol isolation tests for explicit legacy values. Remove the changelog claim and reference for still-open PR microsoft#9617.
* Bump Python package versions for 1.25.0 release Release all 44 publishing workspace distributions with shipping changes since python-1.24.0, including the Python 3.10 removal. Use the approved minor bumps for Core/root, AG-UI, and Declarative, patch bumps for other changed stable integrations, and 261106 stamps for changed alpha/beta packages; no optional cohort-only bump. Update the Core standard-install cohort, apply strict API-based Core floors, and align exact hosting pins. Include the four Python Dependabot updates and the reviewed release batch manifest. Changelog includes the anticipated microsoft#10147 fix; the draft must wait for that PR to merge and be incorporated before release. Lab remains excluded from publication, with only its dependency lock updated. * Fix SQL Server cancellation test exception-info narrowing * Retain deprecated declarative MCP cache parameter and correct release notes Accept legacy positive cache_max_size values with a deprecation warning, without restoring initialized-session caching. Keep per-invocation security isolation and the approved 1.5.0 version, document the compatibility behavior and remaining lifecycle migration, and extend real-protocol isolation tests for explicit legacy values. Remove the changelog claim and reference for still-open PR microsoft#9617. * Simplify deprecated MCP cache parameter handling and undo skill edits
|
Closing this pull request because there was no further activity after the automated warning. (This is an automated message.) |
Motivation & Context
The
ChatResponseandAgentResponseoverview code blocks use an illustrativeupdates = [...]placeholder. Copying either complete block stops atfrom_updatesbefore its serialization examples becauseEllipsisis not a response update. Concrete updates let readers run each overview as written.Description & Review Guide
Content, then construct a single assistant text update in each overview.Actual verification catches two
AttributeErrorinterruptions when copying the original complete blocks, with three passing public API controls. Both final blocks execute through real public imports, including their printed values and both serialization round trips. The actual code blocks compile under Python 3.10 and 3.11. All 482 owningtest_types.pyunit tests pass with zero skips. Normal scoped hooks and the native source commit's normal pre-commit hook pass. Exact source verification. Runtime execution used Ubuntu/CPython 3.13; the full workspace suite, build, typing and live service calls were not run.Related Issue
N/A - trivial change. This replaces illustrative placeholders with minimal concrete inputs in existing overview examples; runtime behavior is unchanged. The separate #9437 edits the
to_updatesmethod examples, not these class overviews. Fresh targeted issue/PR searches found no competing overview repair.AI Assistance
AI assistance details: OpenAI Codex assisted with the example inputs, documentation patch, verification and this description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.