.NET: Propagate ChatHistoryMemoryProvider caller cancellation - #8813
Open
quick_fox (quifox) wants to merge 1 commit into
Open
quick_fox (quifox) wants to merge 1 commit into
quick_fox (quifox) wants to merge 1 commit into
Conversation
quick_fox (quifox)
deployed
to
github-app-auth
September 29, 2026 00:04 — with
GitHub Actions
Active
quick_fox (quifox)
deployed
to
github-app-auth
September 29, 2026 00:04 — with
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The storage cancellation test lacks an UpsertAsync setup and therefore fails without exercising the intended behavior.
Review effort: Balanced
Findings: 1
What changed in this PR
Preserves caller cancellation while retaining best-effort handling for provider-side failures.
Changes:
- Filters search and storage exceptions based on caller cancellation.
- Adds cancellation regression tests.
| File | Description |
|---|---|
ChatHistoryMemoryProvider.cs |
Propagates caller-triggered cancellation. |
ChatHistoryMemoryProviderTests.cs |
Adds search and storage cancellation tests. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+276
to
+277
| using var cts = new CancellationTokenSource(); | ||
| cts.Cancel(); |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation & Context
ChatHistoryMemoryProvider uses best-effort handling for vector search and history storage failures, but its generic exception handlers also swallow caller-triggered cancellation. This can allow search or persistence work to continue after the caller has cancelled the operation.
Description & Review Guide
Related Issue
Fixes #8811
Contribution Checklist