.NET: Dispose AI context streaming enumerators on early exit - #8812
Open
quick_fox (quifox) wants to merge 1 commit into
Open
quick_fox (quifox) wants to merge 1 commit into
quick_fox (quifox) wants to merge 1 commit into
Conversation
quick_fox (quifox)
deployed
to
github-app-auth
September 29, 2026 00:03 — with
GitHub Actions
Active
quick_fox (quifox)
deployed
to
github-app-auth
September 29, 2026 00:03 — with
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The narrowly scoped lifetime fix is correct and covered by targeted regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures .NET AI context streaming decorators dispose inner enumerators when consumers exit early.
Changes:
- Adds asynchronous disposal ownership to both streaming decorators.
- Adds regression tests covering early consumer exit.
| File | Description |
|---|---|
MessageAIContextProviderAgent.cs |
Disposes the inner agent enumerator. |
AIContextProviderChatClient.cs |
Disposes the inner chat enumerator. |
MessageAIContextProviderAgentTests.cs |
Tests early-exit disposal. |
AIContextProviderChatClientTests.cs |
Tests early-exit disposal. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The AI context streaming decorators manually own inner async enumerators. When an outer consumer stops early, those enumerators are not disposed, so iterator cleanup and owned resources may not be released.
Description & Review Guide
Related Issue
Fixes #8810
Contribution Checklist