Python: fix(github-copilot): forward telemetry config to client - #7625
Open
Ruiming Zhao (uuzzrm) wants to merge 1 commit into
Open
Python: fix(github-copilot): forward telemetry config to client#7625Ruiming Zhao (uuzzrm) wants to merge 1 commit into
Ruiming Zhao (uuzzrm) wants to merge 1 commit into
Conversation
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 12, 2026 01:02 — with
GitHub Actions
Active
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 12, 2026 01:02 — with
GitHub Actions
Active
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 12, 2026 01:02 — with
GitHub Actions
Active
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 12, 2026 01:03 — with
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
Pull request overview
Forwards GitHub Copilot CLI telemetry configuration from agent options to the SDK client.
Changes:
- Adds typed telemetry configuration to public options and client settings.
- Prevents telemetry from leaking into session arguments.
- Adds regression tests for both boundaries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_agent.py |
Resolves and forwards telemetry to CopilotClient. |
test_github_copilot_agent.py |
Verifies client forwarding and session exclusion. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
GitHubCopilotAgentcan accept Copilot CLI telemetry configuration, but the setting was not reaching theCopilotClientthat starts the CLI process. That made it impossible to enable the CLI's model and tool spans through the agent configuration described in issue #7624.Description & Review Guide
TelemetryConfigto the public GitHub Copilot options.CopilotClient.create_sessionoptions, where it is not a valid session argument.Related Issue
Fixes #7624
Validation
uv run poe --directory packages/github_copilot test --no-cov— 152 passed, 6 integration tests deselecteduv run poe --directory packages/github_copilot syntax— passeduv run poe --directory packages/github_copilot build— passedgit diff --check— passedThe repository's current MyPy baseline reports two pre-existing errors on
upstream/mainin_parse_usageandBlobAttachment. Pyright could not start in this environment because the installed Node binary has a missing Homebrewllhttplibrary; neither issue is related to this change.Contribution Checklist