Python: Warn when advertised MCP archives are rejected - #7622
Open
Ruiming Zhao (uuzzrm) wants to merge 1 commit into
Open
Python: Warn when advertised MCP archives are rejected#7622Ruiming Zhao (uuzzrm) wants to merge 1 commit into
Ruiming Zhao (uuzzrm) wants to merge 1 commit into
Conversation
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 11, 2026 22:31 — with
GitHub Actions
Active
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 11, 2026 22:31 — with
GitHub Actions
Active
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 11, 2026 22:31 — with
GitHub Actions
Active
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 11, 2026 22:31 — with
GitHub Actions
Active
Ruiming Zhao (uuzzrm)
marked this pull request as ready for review
August 11, 2026 22:32
Ruiming Zhao (uuzzrm)
deployed
to
github-app-auth
August 11, 2026 22:32 — with
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes rejected advertised MCP archive logs to WARNING without changing skill-loading behavior.
Changes:
- Raises archive refusal visibility from DEBUG to WARNING.
- Adds regression coverage for frontmatter name mismatches.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
python/packages/core/agent_framework/_skills.py |
Promotes archive rejection logs. |
python/packages/core/tests/core/test_mcp_skills.py |
Verifies mismatch warnings. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
MCPSkillsSourcecan advertise an archive skill inskill://index.jsonand then return fewer skills when that archive is rejected during download or materialization. The refusal was only logged at DEBUG, so operators could not distinguish a missing skill from one that was never published.This change makes refusals of well-formed, advertised archive entries visible at WARNING. It keeps malformed index entries and MCP
-32002missing-resource responses at DEBUG because those cases can be expected during capability discovery.Description & Review Guide
SKILL.md, invalid UTF-8, and frontmatter name mismatches from DEBUG to WARNING.AI assistance was used to help draft the patch and regression test; I reviewed the resulting diff and ran the relevant test suites.
Related Issue
Fixes #7619
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.