.NET: [Bug]: Request processing fails when web search is enabled beca… - #7611
Open
feiyun0112 wants to merge 1 commit into
Open
.NET: [Bug]: Request processing fails when web search is enabled beca…#7611feiyun0112 wants to merge 1 commit into
feiyun0112 wants to merge 1 commit into
Conversation
…use of an unsupported web_search_options parameter
Contributor
There was a problem hiding this comment.
Pull request overview
Surfaces web_search_options in Chat Completions request mapping and rejects it by default.
Changes:
- Exposes web-search options to mapping callbacks.
- Adds default rejection and an endpoint test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
OpenAIMapOptionsTests.cs |
Tests rejection of web-search options. |
OpenAIChatCompletionsMapOptions.cs |
Marks web-search options unsupported by default. |
OpenAIChatCompletionRequestInfo.cs |
Exposes web-search options. |
ChatClientAgentRunOptionsConverter.cs |
Copies web-search options into request information. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| new StringContent("""{"model":"myModel","messages":[{"role":"user","content":"hello"}],"web_search_options":{}}""", Encoding.UTF8, "application/json")); | ||
|
|
||
| // Assert | ||
| Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7578