Skip to content

Python: Surface A2A preview consent URLs #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeoZhaoo (LobsterQBA) wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −3
Open

Python: Surface A2A preview consent URLs #7606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/packages/foundry_hosting/agent_framework_foundry_hosting/_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def consent_url_from_error(exc: BaseException) -> list[ConsentError] | None:
# "errors" : [
# {
# "name": "Name of the MCP tool that requires consent",
# "type" : "mcp",
# "type" : "mcp" | "a2a_preview",
# "error": {
# "code": "CONSENT_REQUIRED",
# "message": consent_url,
Expand All @@ -146,7 +146,7 @@ def consent_url_from_error(exc: BaseException) -> list[ConsentError] | None:
for error in consent_details["errors"]:
if (
isinstance(error, dict)
and error.get("type") == "mcp" # type: ignore
and error.get("type") in {"mcp", "a2a_preview"} # type: ignore
and "error" in error
and isinstance(error["error"], dict)
and error["error"].get("code") == "CONSENT_REQUIRED" # type: ignore
Expand Down
13 changes: 12 additions & 1 deletion python/packages/foundry_hosting/tests/test_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3626,6 +3626,7 @@ async def test_workflow_rejects_invalid_checkpoint_scope(
def _make_consent_error(
url: str = "https://consent.example.com/auth",
name: str = "Foundry Toolbox",
source_type: str = "mcp",
) -> Exception:
"""Build an exception wrapping a Foundry MCP gateway consent error.

Expand All @@ -3645,7 +3646,7 @@ def _make_consent_error(
"errors": [
{
"name": name,
"type": "mcp",
"type": source_type,
"error": {
"code": "CONSENT_REQUIRED",
"message": url,
Expand All @@ -3663,6 +3664,16 @@ def test_returns_consent_url_when_inner_arg_is_consent_mcp_error(self) -> None:
exc = _make_consent_error("https://example.com/consent", name="my-tool")
assert consent_url_from_error(exc) == [ConsentError(name="my-tool", consent_url="https://example.com/consent")]

def test_returns_consent_url_for_a2a_preview_source(self) -> None:
exc = _make_consent_error(
"https://example.com/a2a-consent",
name="work-iq",
source_type="a2a_preview",
)
assert consent_url_from_error(exc) == [
ConsentError(name="work-iq", consent_url="https://example.com/a2a-consent")
]
Comment on lines +3667 to +3675

def test_returns_none_when_no_mcp_error_in_args(self) -> None:
assert consent_url_from_error(Exception("boom")) is None

Expand Down
Loading