Skip to content

.NET: Fix stop sequence array serialization #6701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VectorPeak wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −1
Open

.NET: Fix stop sequence array serialization #6701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180c4c0
.NET: Fix stop sequence array serialization
VectorPeak Jun 24, 2026
bc4cd11
Potential fix for pull request finding
VectorPeak Jun 24, 2026
1173b79
Merge branch 'main' into fix
VectorPeak Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/ChatCompletions/Models/StopSequences.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public override void Write(Utf8JsonWriter writer, StopSequences? value, JsonSeri
}
else if (value.IsSequences)
{
JsonSerializer.Serialize(writer, value.Sequences, ChatCompletionsJsonContext.Default.IReadOnlyListMessageContentPart);
JsonSerializer.Serialize(writer, value.Sequences, ChatCompletionsJsonContext.Default.IListString);
}
else
{
Expand Down
19 changes: 19 additions & 0 deletions ...s/Microsoft.Agents.AI.Hosting.OpenAI.UnitTests/OpenAIChatCompletionsSerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,25 @@ public void Deserialize_BasicRequest_RoundTrip()
Assert.Equal(request.Messages.Count, roundtripped.Messages.Count);
}

[Fact]
public void Serialize_RequestWithMultipleStopSequences_WritesStringArray()
{
// Arrange
string originalJson = LoadChatCompletionsTraceFile("basic/request.json");
CreateChatCompletion request = JsonSerializer.Deserialize(originalJson, ChatCompletions.ChatCompletionsJsonContext.Default.CreateChatCompletion)!;
request.Stop = StopSequences.FromSequences(["END", "STOP"]);

// Act
string json = JsonSerializer.Serialize(request, ChatCompletions.ChatCompletionsJsonContext.Default.CreateChatCompletion);
using JsonDocument document = JsonDocument.Parse(json);

// Assert
JsonElement stop = document.RootElement.GetProperty("stop");
Assert.Equal(JsonValueKind.Array, stop.ValueKind);
string[] stopValues = stop.EnumerateArray().Select(static e => e.GetString()!).ToArray();
Assert.Equal(["END", "STOP"], stopValues);
}

[Fact]
public void Deserialize_BasicRequest_HasMessages()
{
Expand Down