Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/packages/core/agent_framework/_skills.py
Original file line number Diff line number Diff line change
Expand Up @@ -3092,6 +3092,7 @@ def _search(directory: str, current_depth: int) -> None:
dir_path = Path(directory)
if (dir_path / SKILL_FILE_NAME).is_file():
discovered.append(str(dir_path.absolute()))
return

if current_depth >= MAX_SEARCH_DEPTH:
return
Expand Down
13 changes: 13 additions & 0 deletions python/packages/core/tests/core/test_skills.py
Original file line number Diff line number Diff line change
Expand Up @@ -1917,6 +1917,19 @@ def test_finds_nested_skill(self, tmp_path: Path) -> None:
assert len(dirs) == 1
assert str(sub.absolute()) in dirs[0]

def test_stops_searching_below_skill_boundary(self, tmp_path: Path) -> None:
skill_dir = tmp_path / "parent-skill"
nested_skill_dir = skill_dir / "nested-skill"
nested_skill_dir.mkdir(parents=True)
(skill_dir / "SKILL.md").write_text("---\nname: parent-skill\ndescription: d\n---\n", encoding="utf-8")
(nested_skill_dir / "SKILL.md").write_text(
"---\nname: nested-skill\ndescription: d\n---\n", encoding="utf-8"
)

dirs = FileSkillsSource._discover_skill_directories([str(tmp_path)])

assert dirs == [str(skill_dir.absolute())]

def test_skips_empty_path_string(self) -> None:
dirs = FileSkillsSource._discover_skill_directories(["", " "])
assert dirs == []
Expand Down
Loading