Skip to content

Python: [Breaking] Restructure agent skills to use multi-source architecture #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergeyMenshykh wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Python: [Breaking] Restructure agent skills to use multi-source architecture #5584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bd6f408
migrate skills to multi source architecture
SergeyMenshykh Apr 30, 2026
a0f9f60
Fix ruff lint errors in skills module (ASYNC240, SIM108, E501)
SergeyMenshykh Apr 30, 2026
ac1e20e
fix: collapse multi-line lambdas to single lines to fix pyright errors
SergeyMenshykh Apr 30, 2026
ee5f4d0
fix: replace untyped lambdas with typed inner functions to fix pyrigh…
SergeyMenshykh Apr 30, 2026
726375d
fix: address PR review feedback on docs and prompt template
SergeyMenshykh Apr 30, 2026
89b86fe
refactor: replace dict[str, Skill] with Sequence[Skill] in SkillsProv…
SergeyMenshykh Apr 30, 2026
5675d50
refactor: add read-time resource path validation in _FileSkillsSource
SergeyMenshykh Apr 30, 2026
905de1a
fix: reject str/Path in SkillsProvider constructor to prevent str-as-…
SergeyMenshykh Apr 30, 2026
f0e1493
Address PR #5584 review feedback
SergeyMenshykh May 1, 2026
42a4375
remove skillsproviderbuilder
SergeyMenshykh May 5, 2026
80393b2
Update python/packages/core/agent_framework/_skills.py
SergeyMenshykh May 5, 2026
dbac351
fix: remove dead code and fix sync function call in InlineSkillResour…
SergeyMenshykh May 5, 2026
46045db
remove full_path unnecessary property
SergeyMenshykh May 5, 2026
ff413a7
replace anyio with asyncio.to_thread for file I/O in _FileSkillResource
SergeyMenshykh May 5, 2026
452e19c
simplify awaitable check to return directly
SergeyMenshykh May 5, 2026
1ea9a6a
address PR review feedback for skills refactoring
SergeyMenshykh May 5, 2026
37407ca
address PR review feedback for skills refactoring
SergeyMenshykh May 5, 2026
e3631f0
refactor: move name/description from abstract properties to Skill.__i…
SergeyMenshykh May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions python/packages/core/agent_framework/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,23 @@
)
from ._settings import SecretString, load_settings
from ._skills import (
AggregatingSkillsSource,
DeduplicatingSkillsSource,
DelegatingSkillsSource,
FileSkill,
FileSkillScript,
FileSkillsSource,
FilteringSkillsSource,
InlineSkill,
InlineSkillResource,
InlineSkillScript,
InMemorySkillsSource,
Skill,
SkillResource,
SkillScript,
SkillScriptRunner,
SkillsProvider,
SkillsSource,
)
from ._telemetry import (
AGENT_FRAMEWORK_USER_AGENT,
Expand Down Expand Up @@ -289,6 +301,7 @@
"AgentResponseUpdate",
"AgentRunInputs",
"AgentSession",
"AggregatingSkillsSource",
"Annotation",
"BaseAgent",
"BaseChatClient",
Expand All @@ -313,6 +326,8 @@
"ConversationSplit",
"ConversationSplitter",
"Default",
"DeduplicatingSkillsSource",
"DelegatingSkillsSource",
"Edge",
"EdgeCondition",
"EdgeDuplicationError",
Expand All @@ -333,6 +348,10 @@
"FanOutEdgeGroup",
"FileCheckpointStorage",
"FileHistoryProvider",
"FileSkill",
"FileSkillScript",
"FileSkillsSource",
"FilteringSkillsSource",
"FinalT",
"FinishReason",
"FinishReasonLiteral",
Expand All @@ -350,7 +369,11 @@
"HistoryProvider",
"InMemoryCheckpointStorage",
"InMemoryHistoryProvider",
"InMemorySkillsSource",
"InProcRunnerContext",
"InlineSkill",
"InlineSkillResource",
"InlineSkillScript",
"LocalEvaluator",
"MCPStdioTool",
"MCPStreamableHTTPTool",
Expand Down Expand Up @@ -379,6 +402,7 @@
"SkillScript",
"SkillScriptRunner",
"SkillsProvider",
"SkillsSource",
"SlidingWindowStrategy",
"StepWrapper",
"SubWorkflowRequestMessage",
Expand Down
Loading
Loading