Skip to content

.NET: Skip flaky merge queue integration tests - #10390

Draft
Roger Barreto (rogerbarreto) wants to merge 1 commit into
microsoft:mainfrom
rogerbarreto:skip-flaky-merge-tests
Draft

Roger Barreto (rogerbarreto) wants to merge 1 commit into
microsoft:mainfrom
rogerbarreto:skip-flaky-merge-tests

Conversation

@rogerbarreto

Copy link
Copy Markdown
Member

Motivation & Context

Two nondeterministic live integration scenarios failed consecutive merge-group runs and blocked the queue. The unchanged Foundry hosted suite passed all 48 tests on retry, while the retry exposed a separate net472 MathChat message-count flake.

Description & Review Guide

  • What are the major changes? Temporarily skips the flaky streaming web-search citation test and skips the MathChat external-conversation data row only for .NET Framework. The net10.0 MathChat scenario remains enabled.
  • What is the impact of these changes? Removes two confirmed merge-queue flakes while preserving the unaffected live coverage. Each skip links to the tracking issue for follow-up.
  • What do you want reviewers to focus on? Confirm that the MathChat skip remains scoped to net472 and that the skip reasons provide enough context for later removal.

Validation completed:

  • dotnet build .\tests\Foundry.Hosting.IntegrationTests\Foundry.Hosting.IntegrationTests.csproj -c Debug -f net10.0 --tl:off --warnaserror passed with 0 warnings and 0 errors.
  • dotnet build .\tests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests.csproj -c Debug -f net472 --tl:off --warnaserror passed with 0 warnings and 0 errors.
  • dotnet build .\tests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests.csproj -c Debug -f net10.0 --tl:off --warnaserror passed with 0 warnings and 0 errors.
  • Native Windows dotnet format --verify-no-changes passed for both affected projects. Docker container parity was unavailable because Docker Desktop was not running.
  • Targeted execution confirmed the Foundry test is skipped on net10.0 and the MathChat row is skipped on net472; discovery confirmed the MathChat row remains enabled on net10.0.

Related Issue

Fixes #10389

AI Assistance

  • No material AI assistance was used.
  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: Copilot assisted with the targeted skip implementation, validation, and pull request description.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

Copilot AI balanced review requested due to automatic review settings November 16, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the temporary, scoped integration-test skips.

No open issues 🎉

What changed in this PR

Temporarily skips two flaky .NET live integration scenarios that blocked the merge queue, while preserving unaffected coverage.

Changes:

  • Skips the streaming web-search citation test.
  • Skips the MathChat external-conversation row only for .NET Framework, keeping it enabled on net10.0.
  • Links both skip reasons to tracking issue #10389 for investigation and re-enablement.
File Description
dotnet/​tests/​Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/​DeclarativeWorkflowTest.cs Adds a .NET Framework-only skip for the MathChat row.
dotnet/​tests/​Foundry.Hosting.IntegrationTests/​WebSearchAnnotationsHostedAgentTests.cs Temporarily skips the flaky streaming citation test.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: [Bug]: Flaky live integration scenarios block merge queue

2 participants