Repository navigation
.NET: Skip flaky merge queue integration tests - #10390
Draft
Roger Barreto (rogerbarreto) wants to merge 1 commit into
Draft
Roger Barreto (rogerbarreto) wants to merge 1 commit into
Roger Barreto (rogerbarreto) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the temporary, scoped integration-test skips.
No open issues 🎉
What changed in this PR
Temporarily skips two flaky .NET live integration scenarios that blocked the merge queue, while preserving unaffected coverage.
Changes:
- Skips the streaming web-search citation test.
- Skips the MathChat external-conversation row only for .NET Framework, keeping it enabled on
net10.0. - Links both skip reasons to tracking issue #10389 for investigation and re-enablement.
| File | Description |
|---|---|
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/DeclarativeWorkflowTest.cs | Adds a .NET Framework-only skip for the MathChat row. |
| dotnet/tests/Foundry.Hosting.IntegrationTests/WebSearchAnnotationsHostedAgentTests.cs | Temporarily skips the flaky streaming citation test. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Two nondeterministic live integration scenarios failed consecutive merge-group runs and blocked the queue. The unchanged Foundry hosted suite passed all 48 tests on retry, while the retry exposed a separate
net472MathChat message-count flake.Description & Review Guide
net10.0MathChat scenario remains enabled.net472and that the skip reasons provide enough context for later removal.Validation completed:
dotnet build .\tests\Foundry.Hosting.IntegrationTests\Foundry.Hosting.IntegrationTests.csproj -c Debug -f net10.0 --tl:off --warnaserrorpassed with 0 warnings and 0 errors.dotnet build .\tests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests.csproj -c Debug -f net472 --tl:off --warnaserrorpassed with 0 warnings and 0 errors.dotnet build .\tests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests\Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests.csproj -c Debug -f net10.0 --tl:off --warnaserrorpassed with 0 warnings and 0 errors.dotnet format --verify-no-changespassed for both affected projects. Docker container parity was unavailable because Docker Desktop was not running.net10.0and the MathChat row is skipped onnet472; discovery confirmed the MathChat row remains enabled onnet10.0.Related Issue
Fixes #10389
AI Assistance
AI assistance details: Copilot assisted with the targeted skip implementation, validation, and pull request description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.