Repository navigation
CI: Drop the path filter that matches no directory - #10236
Merged
Vincent Biret (baywet) merged 2 commits intoNov 10, 2026
Merged
Vincent Biret (baywet) merged 2 commits into
Vincent Biret (baywet) merged 2 commits into
Conversation
`python-test-coverage.yml` lists `python/tests/unit/**` under both `pull_request.paths` and `push.paths`, but that directory has never existed in this repository: ```console $ ls python/tests samples $ git log --oneline --all -- python/tests/unit (no output) ``` Every Python test lives under `python/packages/*/tests/`, which the same filter already covers with `python/packages/**`. So the line cannot match anything, and it cannot be responsible for triggering the workflow either. The cost is not runtime, it is what a reader concludes: a paths list is documentation of "what this check watches", and a reader deciding whether their change will be covered reads `python/tests/unit/**` as "unit tests live there". They don't. If tests are ever moved to that location, the entry should come back as part of that move, where it can be tested. Removing two lines from one file; the workflow's behaviour is unchanged because the pattern never matched.
Hyacinth-of-Security (lxcxjxhx)
deployed
to
github-app-auth
November 10, 2026 15:06 — with
GitHub Actions
Active
Hyacinth-of-Security (lxcxjxhx)
deployed
to
github-app-auth
November 10, 2026 15:06 — with
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the coverage workflow path-filter cleanup.
No open issues 🎉
What changed in this PR
Removes an unused path filter from the Python coverage workflow so its triggers reflect the repository’s test layout.
Changes:
- Removes
python/tests/unit/**from both pull request and push path filters. - Retains
python/packages/**, which covers the existing per-package tests, leaving current coverage triggers unchanged.
| File | Description |
|---|---|
.github/workflows/python-test-coverage.yml |
Removes the nonexistent unit-test directory from both trigger filters. |
Review effort: Balanced
Hyacinth-of-Security (lxcxjxhx)
deployed
to
github-app-auth
November 10, 2026 15:22 — with
GitHub Actions
Active
Vincent Biret (baywet)
approved these changes
Nov 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
python-test-coverage.ymllistspython/tests/unit/**in bothpull_request.pathsandpush.paths. That directory has never existed:Every Python test lives under
python/packages/*/tests/, which the same filter already covers viapython/packages/**. So the entry matches nothing — it neither triggers the workflow nor can it ever.The cost is not runtime. A
paths:list is documentation of what a check watches, and a contributor asking "will my change run coverage?" readspython/tests/unit/**as "unit tests live there". They don't, so the list describes a layout the repository does not have.Description & Review Guide
.github/workflows/python-test-coverage.yml.python/packages/**,python/scripts/workspace_poe_tasks.py,.github/scripts/python_check_coverage.py, and the workflow file itself.Related Issue
N/A - trivial change
AI Assistance
Assisted areas: analysis and documentation. A scanner compared every
paths:glob in.github/workflows/against the files present in the repository and reported exactly two unmatched patterns, both this one. I confirmed by listingpython/tests, searching the git history for the directory, and locating where the tests actually live (python/packages/*/tests/). The scanner reported zero unmatched patterns for the other 30 workflows in this repository, and I spot-checked that claim before writing this up. The PR description and commit message are mine.