Skip to content

CI: Drop the path filter that matches no directory - #10236

Merged
Vincent Biret (baywet) merged 2 commits into
microsoft:mainfrom
lxcxjxhx:ci/drop-unmatched-path-filter
Nov 10, 2026
Merged

Vincent Biret (baywet) merged 2 commits into
microsoft:mainfrom
lxcxjxhx:ci/drop-unmatched-path-filter

Conversation

@lxcxjxhx

Copy link
Copy Markdown
Contributor

Motivation & Context

python-test-coverage.yml lists python/tests/unit/** in both pull_request.paths and push.paths. That directory has never existed:

$ ls python/tests
samples
$ git log --oneline --all -- python/tests/unit
(no output)

Every Python test lives under python/packages/*/tests/, which the same filter already covers via python/packages/**. So the entry matches nothing — it neither triggers the workflow nor can it ever.

The cost is not runtime. A paths: list is documentation of what a check watches, and a contributor asking "will my change run coverage?" reads python/tests/unit/** as "unit tests live there". They don't, so the list describes a layout the repository does not have.

Description & Review Guide

  • What are the major changes? Two lines removed from .github/workflows/python-test-coverage.yml.
  • What is the impact of these changes? None on what runs: the pattern never matched a file. Coverage still triggers on python/packages/**, python/scripts/workspace_poe_tasks.py, .github/scripts/python_check_coverage.py, and the workflow file itself.
  • What do you want reviewers to focus on? Whether the entry is a placeholder for a planned move of tests out of per-package directories. If so, closing this and adding the directory when the move happens keeps the two in sync; if the move is not planned, the two lines are noise in a file people read to understand CI.

Related Issue

N/A - trivial change

AI Assistance

  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

Assisted areas: analysis and documentation. A scanner compared every paths: glob in .github/workflows/ against the files present in the repository and reported exactly two unmatched patterns, both this one. I confirmed by listing python/tests, searching the git history for the directory, and locating where the tests actually live (python/packages/*/tests/). The scanner reported zero unmatched patterns for the other 30 workflows in this repository, and I spot-checked that claim before writing this up. The PR description and commit message are mine.

`python-test-coverage.yml` lists `python/tests/unit/**` under both `pull_request.paths`
and `push.paths`, but that directory has never existed in this repository:

```console
$ ls python/tests
samples
$ git log --oneline --all -- python/tests/unit
(no output)
```

Every Python test lives under `python/packages/*/tests/`, which the same filter already
covers with `python/packages/**`. So the line cannot match anything, and it cannot be
responsible for triggering the workflow either.

The cost is not runtime, it is what a reader concludes: a paths list is documentation of
"what this check watches", and a reader deciding whether their change will be covered reads
`python/tests/unit/**` as "unit tests live there". They don't. If tests are ever moved to
that location, the entry should come back as part of that move, where it can be tested.

Removing two lines from one file; the workflow's behaviour is unchanged because the pattern
never matched.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the coverage workflow path-filter cleanup.

No open issues 🎉

What changed in this PR

Removes an unused path filter from the Python coverage workflow so its triggers reflect the repository’s test layout.

Changes:

  • Removes python/tests/unit/** from both pull request and push path filters.
  • Retains python/packages/**, which covers the existing per-package tests, leaving current coverage triggers unchanged.
File Description
.github/​workflows/​python-test-coverage.yml Removes the nonexistent unit-test directory from both trigger filters.

Review effort: Balanced

@baywet
Vincent Biret (baywet) added this pull request to the merge queue Nov 10, 2026
Merged via the queue into microsoft:main with commit 7bfd07b Nov 10, 2026
31 checks passed

This branch was successfully deployed

1 active deployment
github-app-auth — f96e91f7 Deployed Nov 10, 2026 by lxcxjxhx via add_label #27502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants